Bug 1299558 - Review Request: python-inifile - A small INI library for Python
Summary: Review Request: python-inifile - A small INI library for Python
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Robert Kuska
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-01-18 15:50 UTC by Charalampos Stratakis
Modified: 2016-04-18 10:17 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-01-30 18:22:21 UTC
rkuska: fedora-review+


Attachments (Terms of Use)

Description Charalampos Stratakis 2016-01-18 15:50:13 UTC
Spec URL: http://copr-dist-git.fedorainfracloud.org/cgit/cstratak/python-inifile/python-inifile.git/plain/python-inifile.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/cstratak/python-inifile/fedora-rawhide-x86_64/00154174-python-inifile/python-inifile-0.3-1.fc24.src.rpm
Description: Review request for python-inifile. This library is required for the Lektor framework from Armin Ronacher (which is to be packaged on a later date)
Fedora Account System Username: cstratak

My first package, so a sponsor will be needed.

Comment 1 Robert Kuska 2016-01-20 10:28:18 UTC
The check phase in specfile is redudant, no tests are run nor present in package.

"Ran 0 tests in 0.000s"

It's probably better to use %{version} macro in Source0 so you don't have to edit the link everytime you update the package. 

Also you've defined %{sum} macro and used it only in main package description even though both subpackages could use it as well in their description.


These are just minor issues and otherwise it looks nice! :)

Comment 3 Robert Kuska 2016-01-20 12:41:53 UTC
Looks good, approved.

Comment 4 Miroslav Suchý 2016-01-20 13:29:51 UTC
Looks good to me as well.

APPROVED

Comment 5 Gwyn Ciesla 2016-01-20 16:49:54 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/python-inifile

Comment 6 Fedora Update System 2016-01-21 10:13:46 UTC
python-inifile-0.3-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-843bee847e

Comment 7 Fedora Update System 2016-01-21 10:28:01 UTC
python-inifile-0.3-2.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-98638e0778

Comment 8 Fedora Update System 2016-01-21 15:41:42 UTC
python-inifile-0.3-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-18c1b36a18

Comment 9 Fedora Update System 2016-01-22 04:56:27 UTC
python-inifile-0.3-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-843bee847e

Comment 10 Fedora Update System 2016-01-22 07:55:51 UTC
python-inifile-0.3-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-18c1b36a18

Comment 11 Fedora Update System 2016-01-23 21:29:32 UTC
python-inifile-0.3-2.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-98638e0778

Comment 12 Fedora Update System 2016-01-30 18:22:18 UTC
python-inifile-0.3-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2016-02-02 00:53:22 UTC
python-inifile-0.3-2.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2016-02-06 02:24:52 UTC
python-inifile-0.3-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.