Bug 1299843
| Summary: | Review Request: nodejs-buffertools - Working with node.js buffers made easy | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jared Smith <jsmith.fedora> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-02-25 12:41:05 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 956806, 1273150 | ||
|
Description
Jared Smith
2016-01-19 11:43:16 UTC
Successful scratch build in f24-nodejs4 side tag is at http://koji.fedoraproject.org/koji/taskinfo?taskID=12604449 Updated packages to fix a missing directory Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-buffertools/nodejs-buffertools.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-buffertools/nodejs-buffertools-2.1.3-3.fc24.src.rpm jsmith's scratch build of nodejs-buffertools-2.1.3-3.fc24.src.rpm for f24-nodejs4 failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12605071 jsmith's scratch build of nodejs-buffertools-2.1.3-3.fc24.src.rpm for f24-nodejs4 failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12606090 jsmith's scratch build of nodejs-buffertools-2.1.3-4.fc24.src.rpm for f24-nodejs4 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12606266 Updated packages to fix building on ARM. Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-buffertools/nodejs-buffertools.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-buffertools/nodejs-buffertools-2.1.3-4.fc24.src.rpm Successful scratch build at http://koji.fedoraproject.org/koji/taskinfo?taskID=12606266 Updated packages to add a patch to use the npm(bindings) module instead of hard-coding the path to the native code. Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-buffertools/nodejs-buffertools.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-buffertools/nodejs-buffertools-2.1.3-6.fc24.src.rpm Starting a scratch build now... jsmith's scratch build of nodejs-buffertools-2.1.3-6.fc24.src.rpm for f24-nodejs4 failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12606554 jsmith's scratch build of nodejs-buffertools-2.1.3-6.fc24.src.rpm for f24-nodejs4 failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12606583 jsmith's scratch build of nodejs-buffertools-2.1.3-7.fc24.src.rpm for f24-nodejs4 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12606706 And finally, a build that works on ARM and with the npm(bindings) module. Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-buffertools/nodejs-buffertools.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-buffertools/nodejs-buffertools-2.1.3-7.fc24.src.rpm Review: + package builds fine in f24-nodejs4 tag which is going to get merged into f24 soon + Source verified with upstream as (sha256sum) upstream source:1a650a9de86eb1e1e1930812efaa88ef408e67e3017426b6745f66a958f377f0 buffertools-2.1.3.tgz.1 srpm source: 1a650a9de86eb1e1e1930812efaa88ef408e67e3017426b6745f66a958f377f0 buffertools-2.1.3.tgz.1 + License is "ISC" which is valid license and included in LICENSE file. + package follows nodejs packaging guidelines. Suggestions: 1) "%install" line is missing which cause few rpmlint "rpm-buildroot-usage" warnings. Just add that line back. APPROVED. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/nodejs-buffertools Any update here? |