Bug 1299843 - Review Request: nodejs-buffertools - Working with node.js buffers made easy
Summary: Review Request: nodejs-buffertools - Working with node.js buffers made easy
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: nodejs-reviews 1273150
TreeView+ depends on / blocked
 
Reported: 2016-01-19 11:43 UTC by Jared Smith
Modified: 2016-02-25 12:41 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-02-25 12:41:05 UTC
Type: ---
Embargoed:
panemade: fedora-review+

Attachments (Terms of Use)

Description Jared Smith 2016-01-19 11:43:16 UTC 
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-buffertools/nodejs-buffertools.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-buffertools/nodejs-buffertools-2.1.3-2.fc24.src.rpm
Description: Working with node.js buffers made easy
Fedora Account System Username: jsmith
Comment 1 Jared Smith 2016-01-19 11:45:57 UTC 
Successful scratch build in f24-nodejs4 side tag is at http://koji.fedoraproject.org/koji/taskinfo?taskID=12604449
Comment 2 Jared Smith 2016-01-19 12:01:35 UTC 
Updated packages to fix a missing directory

Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-buffertools/nodejs-buffertools.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-buffertools/nodejs-buffertools-2.1.3-3.fc24.src.rpm
Comment 3 Upstream Release Monitoring 2016-01-19 12:15:39 UTC 
jsmith's scratch build of nodejs-buffertools-2.1.3-3.fc24.src.rpm for f24-nodejs4 failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12605071
Comment 4 Upstream Release Monitoring 2016-01-19 13:34:07 UTC 
jsmith's scratch build of nodejs-buffertools-2.1.3-3.fc24.src.rpm for f24-nodejs4 failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12606090
Comment 5 Upstream Release Monitoring 2016-01-19 13:59:03 UTC 
jsmith's scratch build of nodejs-buffertools-2.1.3-4.fc24.src.rpm for f24-nodejs4 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12606266
Comment 6 Jared Smith 2016-01-19 14:01:43 UTC 
Updated packages to fix building on ARM.

Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-buffertools/nodejs-buffertools.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-buffertools/nodejs-buffertools-2.1.3-4.fc24.src.rpm

Successful scratch build at http://koji.fedoraproject.org/koji/taskinfo?taskID=12606266
Comment 7 Jared Smith 2016-01-19 14:21:42 UTC 
Updated packages to add a patch to use the npm(bindings) module instead of hard-coding the path to the native code.

Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-buffertools/nodejs-buffertools.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-buffertools/nodejs-buffertools-2.1.3-6.fc24.src.rpm

Starting a scratch build now...
Comment 8 Upstream Release Monitoring 2016-01-19 14:23:55 UTC 
jsmith's scratch build of nodejs-buffertools-2.1.3-6.fc24.src.rpm for f24-nodejs4 failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12606554
Comment 9 Upstream Release Monitoring 2016-01-19 14:27:35 UTC 
jsmith's scratch build of nodejs-buffertools-2.1.3-6.fc24.src.rpm for f24-nodejs4 failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12606583
Comment 10 Upstream Release Monitoring 2016-01-19 14:41:22 UTC 
jsmith's scratch build of nodejs-buffertools-2.1.3-7.fc24.src.rpm for f24-nodejs4 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12606706
Comment 11 Jared Smith 2016-01-19 14:42:06 UTC 
And finally, a build that works on ARM and with the npm(bindings) module.

Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-buffertools/nodejs-buffertools.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-buffertools/nodejs-buffertools-2.1.3-7.fc24.src.rpm
Comment 12 Parag AN(पराग) 2016-01-19 14:52:41 UTC 
Review:

+ package builds fine in f24-nodejs4 tag which is going to get merged into f24 soon

+ Source verified with upstream as (sha256sum)
upstream source:1a650a9de86eb1e1e1930812efaa88ef408e67e3017426b6745f66a958f377f0  buffertools-2.1.3.tgz.1
srpm source: 1a650a9de86eb1e1e1930812efaa88ef408e67e3017426b6745f66a958f377f0  buffertools-2.1.3.tgz.1

+ License is "ISC" which is valid license and included in LICENSE file.

+ package follows nodejs packaging guidelines.

Suggestions:
1) "%install" line is missing which cause few rpmlint "rpm-buildroot-usage" warnings. Just add that line back.

APPROVED.
Comment 13 Gwyn Ciesla 2016-01-19 17:22:43 UTC 
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/nodejs-buffertools
Comment 14 Parag AN(पराग) 2016-02-25 04:29:04 UTC 
Any update here?
Note You need to log in before you can comment on or make changes to this bug.