Bug 1300407

Summary: RFE: AUDIT_NETFILTER_PKT events are not normalized
Product: [Fedora] Fedora Reporter: Steve Grubb <sgrubb>
Component: kernelAssignee: Paul Moore <pmoore>
Status: CLOSED DEFERRED QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: medium    
Version: rawhideCC: gansalmon, itamar, jonathan, kernel-maint, madhu.chinakonda, mchehab, rbriggs
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-06-02 19:44:34 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Steve Grubb 2016-01-20 17:13:02 UTC 
Description of problem:
The AUDIT_NETFILTER_PKT audit events are not normalized. They swing fields in and out based on settings rather than changing the value of the event. Here's one example in ./net/netfilter/xt_AUDIT.c:

        if (ntohs(ih->frag_off) & IP_OFFSET) {
                audit_log_format(ab, " frag=1");
                return;
        }

frag should always be set like:
audit_log_format(ab, " frag=%d", ntohs(ih->frag_off) & IP_OFFSET);


Version-Release number of selected component (if applicable):
4.3.3
Comment 1 Steve Grubb 2016-01-21 20:43:05 UTC 
There was a discussion upstream about some enhancements that could be made to make iptables based audit events more usable:

https://www.redhat.com/archives/linux-audit/2013-February/msg00020.html
Comment 2 Paul Moore 2016-06-02 19:44:34 UTC 
Closing this as we are tracking upstream RFEs on GitHub now:

* https://github.com/linux-audit/audit-kernel/issues/11