Bug 1300407 - RFE: AUDIT_NETFILTER_PKT events are not normalized
Summary: RFE: AUDIT_NETFILTER_PKT events are not normalized
Keywords:
Status: CLOSED DEFERRED
Alias: None
Product: Fedora
Classification: Fedora
Component: kernel
Version: rawhide
Hardware: All
OS: Linux
medium
low
Target Milestone: ---
Assignee: Paul Moore
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-01-20 17:13 UTC by Steve Grubb
Modified: 2016-06-02 19:44 UTC (History)
7 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2016-06-02 19:44:34 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Steve Grubb 2016-01-20 17:13:02 UTC
Description of problem:
The AUDIT_NETFILTER_PKT audit events are not normalized. They swing fields in and out based on settings rather than changing the value of the event. Here's one example in ./net/netfilter/xt_AUDIT.c:

        if (ntohs(ih->frag_off) & IP_OFFSET) {
                audit_log_format(ab, " frag=1");
                return;
        }

frag should always be set like:
audit_log_format(ab, " frag=%d", ntohs(ih->frag_off) & IP_OFFSET);


Version-Release number of selected component (if applicable):
4.3.3

Comment 1 Steve Grubb 2016-01-21 20:43:05 UTC
There was a discussion upstream about some enhancements that could be made to make iptables based audit events more usable:

https://www.redhat.com/archives/linux-audit/2013-February/msg00020.html

Comment 2 Paul Moore 2016-06-02 19:44:34 UTC
Closing this as we are tracking upstream RFEs on GitHub now:

* https://github.com/linux-audit/audit-kernel/issues/11


Note You need to log in before you can comment on or make changes to this bug.