Bug 1301032

Summary:	[georep+tiering]: Hardlink sync is broken if master volume is tiered
Product:	[Community] GlusterFS	Reporter:	Saravanakumar <sarumuga>
Component:	geo-replication	Assignee:	Saravanakumar <sarumuga>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	urgent	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	avishwan, bugs, chrisw, csaba, nlevinki, rhinduja, sankarshan, storage-qa-internal
Target Milestone:	---	Keywords:	ZStream
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	glusterfs-3.8rc2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1300682
Clones:	1302979 (view as bug list)		Environment:
Last Closed:	2016-06-16 13:55:37 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1300682
Bug Blocks:	1302979

Comment 1 Vijay Bellur 2016-01-22 11:38:14 UTC

REVIEW: http://review.gluster.org/13281 (geo-rep: Handle hardlink in Tiering based volume) posted (#2) for review on master by Saravanakumar Arumugam (sarumuga)

Comment 2 Vijay Bellur 2016-01-25 06:05:16 UTC

REVIEW: http://review.gluster.org/13281 (geo-rep: Handle hardlink in Tiering based volume) posted (#3) for review on master by Saravanakumar Arumugam (sarumuga)

Comment 3 Vijay Bellur 2016-01-27 12:40:26 UTC

REVIEW: http://review.gluster.org/13281 (geo-rep: Handle hardlink in Tiering based volume) posted (#4) for review on master by Saravanakumar Arumugam (sarumuga)

Comment 4 Vijay Bellur 2016-01-28 08:45:40 UTC

REVIEW: http://review.gluster.org/13281 (geo-rep: Handle hardlink in Tiering based volume) posted (#5) for review on master by Saravanakumar Arumugam (sarumuga)

Comment 5 Vijay Bellur 2016-01-28 09:37:39 UTC

REVIEW: http://review.gluster.org/13281 (geo-rep: Handle hardlink in Tiering based volume) posted (#6) for review on master by Aravinda VK (avishwan)

Comment 6 Vijay Bellur 2016-01-28 13:22:48 UTC

REVIEW: http://review.gluster.org/13281 (geo-rep: Handle hardlink in Tiering based volume) posted (#7) for review on master by Venky Shankar (vshankar)

Comment 7 Vijay Bellur 2016-01-29 05:42:29 UTC

REVIEW: http://review.gluster.org/13281 (geo-rep: Handle hardlink in Tiering based volume) posted (#8) for review on master by Saravanakumar Arumugam (sarumuga)

Comment 8 Vijay Bellur 2016-02-08 08:22:55 UTC

REVIEW: http://review.gluster.org/13281 (geo-rep: Handle hardlink in Tiering based volume) posted (#9) for review on master by Saravanakumar Arumugam (sarumuga)

Comment 9 Vijay Bellur 2016-02-09 13:59:21 UTC

REVIEW: http://review.gluster.org/13281 (geo-rep: Handle hardlink in Tiering based volume) posted (#10) for review on master by Saravanakumar Arumugam (sarumuga)

Comment 10 Vijay Bellur 2016-02-26 09:44:27 UTC

COMMIT: http://review.gluster.org/13281 committed in master by Venky Shankar (vshankar) 
------
commit 3f9632cd655f43fa66cca981b37cbfb09ab1d352
Author: Saravanakumar Arumugam <sarumuga>
Date:   Fri Jan 22 16:58:13 2016 +0530

    geo-rep: Handle hardlink in Tiering based volume
    
    Problem:
    Hardlinks are synced as Sticky bit files to Slave in
    a Tiering based volume.
    In a Tiering based volume, cold tier is hashed subvolume
    and geo-rep captures all namespace operations in cold tier.
    
    While syncing a file and its corresponding hardlink, it is
    recorded as MKNOD in cold tier(for both) and
    We end up creating two different files in Slave.
    
    Solution:
    If MKNOD with Sticky bit set is present, record it as LINK.
    This way it will create a HARDLINK if source file exists (on slave),
    else it will create a new file.
    
    This way, Slave can create Hardlink file itself (instead
    of creating a new file) in case of hardlink.
    
    Change-Id: Ic50dc6e64df9ed01799c30539a33daace0abe6d4
    BUG: 1301032
    Signed-off-by: Saravanakumar Arumugam <sarumuga>
    Signed-off-by: Aravinda VK <avishwan>
    Reviewed-on: http://review.gluster.org/13281
    Smoke: Gluster Build System <jenkins.com>
    CentOS-regression: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>

Comment 11 Niels de Vos 2016-06-16 13:55:37 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user