Bug 130110

Summary: Can't choose not to have signature
Product: [Fedora] Fedora Reporter: Tim Waugh <twaugh>
Component: evolutionAssignee: Matthew Barnes <mbarnes>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: zcerza
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: FC6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2007-01-02 10:22:20 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Tim Waugh 2004-08-17 08:53:48 UTC
Description of problem:
I can't prevent evolution appending an autogenerated signature to my
composed emails, other than by turning it off on a per-email basis.

Version-Release number of selected component (if applicable):
evolution-1.5.93-1, also 1.5.92.2-2

How reproducible:
100%

Steps to Reproduce:
1. Tools->Settings, select default account, Edit
2. Select 'None' in the Signature spin button, then Okay
3. Select default account, Edit, observe signature setting
4. Compose new email, observe autogenerated signature

Actual results:
Signature setting does not stick in settings.
New messages contain autogenerated signature.

Expected results:
Signature setting can be altered.

Comment 1 Dave Malcolm 2004-09-20 19:40:06 UTC
Works for me in Evo 2.0.0, and, IIRC, in 1.5.94.1

What do the following commands output for you?
gconftool-2 --get /apps/evolution/mail/accounts
gconftool-2 --get /apps/evolution/mail/signatures


Comment 2 Tim Waugh 2004-09-27 16:55:04 UTC
[<?xml version="1.0"?>
<account name="tim" uid="0"
enabled="true"><identity><name>Tim
Waugh</name><addr-spec>tim</addr-spec><signature
uid="1092049501.6373.0"/></identity><source
save-passwd="false" keep-on-server="false" auto-check="true"
auto-check-timeout="1"><url>mbox:/var/spool/mail/tim</url></source><transport
save-passwd="false"><url>sendmail:</url></transport><drafts-folder>email://local@local/Drafts</drafts-folder><sent-folder>email://local@local/Sent</sent-folder><auto-cc
always="false"><recipients></recipients></auto-cc><auto-bcc
always="false"><recipients></recipients></auto-bcc><pgp
encrypt-to-self="true" always-trust="false" always-sign="true"
no-imip-sign="false"/><smime sign-default="false"
encrypt-default="false" encrypt-to-self="false"/></account>
,<?xml version="1.0"?>
<account name="tim" uid="1"
enabled="true"><identity><name>Tim
Waugh</name><addr-spec>tim</addr-spec><reply-to></reply-to><organization></organization><signature
uid="1092049501.6373.0"/></identity><source
save-passwd="true" keep-on-server="false" auto-check="true"
auto-check-timeout="20"><url>pop://tim.waugh.com</url></source><transport
save-passwd="false"><url>smtp://smtp.ntlworld.com</url></transport><drafts-folder>email://local@local/Drafts</drafts-folder><sent-folder>email://local@local/Sent</sent-folder><auto-cc
always="false"><recipients></recipients></auto-cc><auto-bcc
always="false"><recipients></recipients></auto-bcc><pgp
encrypt-to-self="true" always-trust="false" always-sign="true"
no-imip-sign="false"><key-id></key-id></pgp><smime
sign-default="false" encrypt-default="false"
encrypt-to-self="false"><sign-key-id></sign-key-id><encrypt-key-id></encrypt-key-id></smime></account>
,<?xml version="1.0"?>
<account name="nick" uid="2"
enabled="true"><identity><name>Nick
Waugh</name><addr-spec>nick</addr-spec><reply-to></reply-to><organization></organization><signature
uid="1092049501.6373.0"/></identity><source
save-passwd="true" keep-on-server="false" auto-check="false"
auto-check-timeout="0"><url>pop://nick.waugh7.com</url></source><transport
save-passwd="false"><url>smtp://smtp.ntlworld.com</url></transport><drafts-folder>email://local@local/Drafts</drafts-folder><sent-folder>email://local@local/Sent</sent-folder><auto-cc
always="false"><recipients></recipients></auto-cc><auto-bcc
always="false"><recipients></recipients></auto-bcc><pgp
encrypt-to-self="false" always-trust="false" always-sign="false"
no-imip-sign="false"><key-id></key-id></pgp><smime
sign-default="false" encrypt-default="false"
encrypt-to-self="false"/></account>
]


[<?xml version="1.0"?>
<signature name="Autogenerated" uid="1092049501.6373.0"
auto="true" format="text/html"/>
]


Comment 3 Dave Malcolm 2004-09-27 18:08:34 UTC
Thanks for the info.  At stage 3 in your "Steps to Reproduce" above,
what setting do you observe?  "None", or "Autogenerated".

If you run gconf-editor, browse to /apps/evolution/mail/accounts, you
will see a list of mini-XML files.  Scroll across and you will see an
element 
<signature
uid="UID-VALUE-MATCHING-THE-ONE-IN-/apps/evolution/mail/signatures"/>

To have "None" for the signature, I'd expect you to be seeing a blank
UID, i.e. an element like 

<signature uid=""/>

Alternatively you can use gconftool-2 to extract the value as a list
of short XML files to stdout.

Please retry the "Steps to Reproduce", reporting the state of the
<signature> element (if any) of the relevant account at each stage. 
Does it ever change?  Thanks.


Comment 4 Tim Waugh 2004-09-27 18:13:26 UTC
At step 3 it reverted to 'Autogenerated'.

When trying again with gconf-editor open, I never see an empty uid
tag.  It always has the autogenerated UID.

Comment 5 Dave Malcolm 2004-09-27 18:28:15 UTC
Thanks.  Looks like it's failing to write the changed value back into
GConf, for some reason.  I'm going to dig into the relevant part of
the source code...

Comment 6 Dave Malcolm 2004-09-28 01:36:17 UTC
Notes to self about this:

Code in evolution/mail/mail-account-gui.c: sig_fill_menu populates the
menu, uses g_object_set_data (menu_item, "sig", ptr to ESignature),
with NULL for the "None" entry.

callback sig_activate is called when you edit that part of the GUI; it
sets gui->sig_uid, but does this force a writeback to GConf?  Perhaps
not, and this may be the bug...

mail_account_gui_save is called on clicking on the OK button; this
ought to be making the changes to GConf...


Comment 7 Dave Malcolm 2004-09-28 01:50:52 UTC
If you run evolution from the command line, does anything get output
to stdout when you try to reproduce this bug?

Which of the above accounts are you able to reproduce this bug on? 
All of them, or just some of them?

Are you able to manually edit the GConf key by editing the signature
UID in the gconf-editor?

Can you give me access to a machine where this is reproducable?

Comment 8 Tim Waugh 2004-09-28 08:21:29 UTC
evolution-shell-Message: Killing old version of evolution-data-server...
asked to activate component_id
`OAFIID:GNOME_Evolution_Addressbook_Component:2.0'
asked to activate component_id
`OAFIID:GNOME_Evolution_Addressbook_Component:2.0'
asked to activate component_id
`OAFIID:GNOME_Evolution_Addressbook_Autocompletion_ConfigControl:2.0'
asked to activate component_id
`OAFIID:GNOME_Evolution_SMime_CertificateManager_ConfigControl:2.0'
Here is the output from the command line invocation:

(evolution:3148): Gtk-CRITICAL **: file gtktreesortable.c: line 137
(gtk_tree_sortable_set_sort_column_id): assertion
`GTK_IS_TREE_SORTABLE (sortable)' failed
account gui setup
checking writable option 'auth' perms=00000040
checking writable option 'use_ssl' perms=00000010
checking writable option 'keep_on_server' perms=00000000
checking writable option 'disable_extensions' perms=00000000
checking writable option 'auth' perms=00000040
checking writable option 'use_ssl' perms=00000010
checking writable option 'auth' perms=00000040
checking writable option 'use_ssl' perms=00000010
checking writable option 'auth' perms=00000040
checking writable option 'use_ssl' perms=00000010
checking writable option 'auth' perms=00000040
checking writable option 'use_ssl' perms=00000010
checking writable option 'auth' perms=00000040
checking writable option 'use_ssl' perms=00000010
checking writable option 'keep_on_server' perms=00000000
checking writable option 'disable_extensions' perms=00000000

The problem is visible on all three accounts.

If I change the setting manually with gconf-editor, it sticks.  If I
then change the setting in evolution to "Autogenerated", click OK, and
then try changing it back to "None", it stays at "Autogenerated".


Comment 10 Dave Malcolm 2004-09-28 16:58:27 UTC
I'd thought that perhaps the complex logic that determines if an
account has changed was failing due to some detail of the account, but
I just tried the first of your accounts on my system, and it works fine.

What architecture is this on, BTW?

Comment 11 Tim Waugh 2004-09-28 17:07:22 UTC
This is on an i686 machine.

Comment 12 Dave Malcolm 2004-09-28 19:00:53 UTC
*** Bug 132215 has been marked as a duplicate of this bug. ***

Comment 14 Matthew Barnes 2007-01-01 21:30:05 UTC
Is this problem still present on Fedora Core 6 or later?

Comment 15 Tim Waugh 2007-01-02 10:22:20 UTC
Don't think so.