Bug 1302725
| Summary: | Bookmarks - 'public' attribute not mandatory | ||
|---|---|---|---|
| Product: | Red Hat Satellite | Reporter: | Roman Plevka <rplevka> |
| Component: | API | Assignee: | satellite6-bugs <satellite6-bugs> |
| Status: | CLOSED ERRATA | QA Contact: | Roman Plevka <rplevka> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | Nightly | CC: | bkearney, jcallaha |
| Target Milestone: | Unspecified | ||
| Target Release: | Unused | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | http://projects.theforeman.org/issues/13437 | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-02-21 16:49:54 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Created redmine issue http://projects.theforeman.org/issues/13437 from this bug Moving to POST since upstream bug http://projects.theforeman.org/issues/13437 has been closed VERIFIED
sat6.3 snap3
public set to false if not set.
curl -ku admin:changeme -H Content-Type:application/json -d "{\"name\":\"foo\",\"query\":\"bar\", \"controller\":\"organizations\"}" "https://$(hostname)/api/bookmarks"
# curl -ku admin:changeme "https://$(hostname)/api/bookmarks?search=foo"
{
"total": 15,
"subtotal": 1,
"page": 1,
"per_page": 20,
"search": "foo",
"sort": {
"by": null,
"order": null
},
"results": [{"name":"foo","controller":"organizations","query":"bar","public":false,"id":15,"owner_id":3,"owner_type":"User"}]
}
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2018:0336 |
Description of problem: Creation of a bookmark via API does not require 'public' attribute to be set, which results in 'public': null in the created entity. Version-Release number of selected component (if applicable): # rpm -qa katello katello-2.5.0-3.nightly.el7.noarch # rpm -qa foreman foreman-1.11.0-0.develop.201601241936gitd600a50.el7.noarch # rpm -qa foreman-* foreman-gce-1.11.0-0.develop.201601241936gitd600a50.el7.noarch foreman-libvirt-1.11.0-0.develop.201601241936gitd600a50.el7.noarch foreman-release-1.11.0-0.develop.201601241936gitd600a50.el7.noarch foreman-vmware-1.11.0-0.develop.201601241936gitd600a50.el7.noarch foreman-selinux-1.11.0-0.develop.201601041235git6234447.el7.noarch foreman-ovirt-1.11.0-0.develop.201601241936gitd600a50.el7.noarch foreman-postgresql-1.11.0-0.develop.201601241936gitd600a50.el7.noarch foreman-compute-1.11.0-0.develop.201601241936gitd600a50.el7.noarch foreman-proxy-1.11.0-0.develop.201601211502git0a70eea.el7.noarch foreman-release-scl-2-1.el7.x86_64 foreman-debug-1.11.0-0.develop.201601241936gitd600a50.el7.noarch # rpm -qa *-katello pulp-katello-0.4-3.el7.noarch tfm-rubygem-katello-2.5.0-.201601221853git276ce3d1.nightly.el7.noarch How reproducible: always Steps to Reproduce: 1. send a POST request to <fqdn>/api/bookmarks specifying only a name, query and a controller attribute. e.g.: curl -ku admin:changeme -H Content-Type:application/json -d "{\"name\":\"foo\",\"query\":\"bar\", \"controller\":\"organizations\"}" 'https://<FQDN>/api/bookmarks' Actual results: {"name":"foo","controller":"organizations","query":"bar","public":null,"id":12,"owner_id":3,"owner_type":"User"} Expected results: public attribute should be set - so either an error should be returned forcing user to specify True/False. Or a default value should be assigned (False)