Red Hat Satellite engineering is moving the tracking of its product development work on Satellite to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "Satellite project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs will be migrated starting at the end of May. If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "Satellite project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/SAT-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1302725 - Bookmarks - 'public' attribute not mandatory
Summary: Bookmarks - 'public' attribute not mandatory
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: API
Version: Nightly
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: Unspecified
Assignee: satellite6-bugs
QA Contact: Roman Plevka
URL: http://projects.theforeman.org/issues...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-01-28 13:30 UTC by Roman Plevka
Modified: 2021-07-21 08:42 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-02-21 16:49:54 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Foreman Issue Tracker 13437 0 None None None 2016-04-22 15:05:03 UTC

Description Roman Plevka 2016-01-28 13:30:39 UTC 
Description of problem:
Creation of a bookmark via API does not require 'public' attribute to be set, which results in 'public': null in the created entity.


Version-Release number of selected component (if applicable):
# rpm -qa katello
katello-2.5.0-3.nightly.el7.noarch
# rpm -qa foreman
foreman-1.11.0-0.develop.201601241936gitd600a50.el7.noarch
# rpm -qa foreman-*
foreman-gce-1.11.0-0.develop.201601241936gitd600a50.el7.noarch
foreman-libvirt-1.11.0-0.develop.201601241936gitd600a50.el7.noarch
foreman-release-1.11.0-0.develop.201601241936gitd600a50.el7.noarch
foreman-vmware-1.11.0-0.develop.201601241936gitd600a50.el7.noarch
foreman-selinux-1.11.0-0.develop.201601041235git6234447.el7.noarch
foreman-ovirt-1.11.0-0.develop.201601241936gitd600a50.el7.noarch
foreman-postgresql-1.11.0-0.develop.201601241936gitd600a50.el7.noarch
foreman-compute-1.11.0-0.develop.201601241936gitd600a50.el7.noarch
foreman-proxy-1.11.0-0.develop.201601211502git0a70eea.el7.noarch
foreman-release-scl-2-1.el7.x86_64
foreman-debug-1.11.0-0.develop.201601241936gitd600a50.el7.noarch
# rpm -qa *-katello
pulp-katello-0.4-3.el7.noarch
tfm-rubygem-katello-2.5.0-.201601221853git276ce3d1.nightly.el7.noarch

How reproducible:
always

Steps to Reproduce:
1. send a POST request to <fqdn>/api/bookmarks specifying only a name, query and a controller attribute.

e.g.:

curl -ku admin:changeme -H Content-Type:application/json -d "{\"name\":\"foo\",\"query\":\"bar\", \"controller\":\"organizations\"}" 'https://<FQDN>/api/bookmarks'

Actual results:

{"name":"foo","controller":"organizations","query":"bar","public":null,"id":12,"owner_id":3,"owner_type":"User"}

Expected results:

public attribute should be set - so either an error should be returned forcing user to specify True/False. Or a default value should be assigned (False)
Comment 1 Roman Plevka 2016-01-28 13:31:21 UTC 
Created redmine issue http://projects.theforeman.org/issues/13437 from this bug
Comment 2 Bryan Kearney 2016-05-10 18:14:44 UTC 
Moving to POST since upstream bug http://projects.theforeman.org/issues/13437 has been closed
Comment 4 Roman Plevka 2016-10-14 12:07:44 UTC 
VERIFIED
sat6.3 snap3

public set to false if not set.

curl -ku admin:changeme -H Content-Type:application/json -d "{\"name\":\"foo\",\"query\":\"bar\", \"controller\":\"organizations\"}" "https://$(hostname)/api/bookmarks"

# curl -ku admin:changeme "https://$(hostname)/api/bookmarks?search=foo"
{
  "total": 15,
  "subtotal": 1,
  "page": 1,
  "per_page": 20,
  "search": "foo",
  "sort": {
    "by": null,
    "order": null
  },
  "results": [{"name":"foo","controller":"organizations","query":"bar","public":false,"id":15,"owner_id":3,"owner_type":"User"}]
}
Comment 5 Satellite Program 2018-02-21 16:49:54 UTC 
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA.

For information on the advisory, and where to find the updated files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:0336
Note You need to log in before you can comment on or make changes to this bug.