Bug 1302810

Summary: [RFE] Orchestration templates auto collected from provider should be hidden from Services -> Catalogs -> Orchestration Templates
Product: Red Hat CloudForms Management Engine Reporter: Bill Wei <bilwei>
Component: UI - OPSAssignee: Milan Zázrivec <mzazrivec>
Status: CLOSED ERRATA QA Contact: Shveta <sshveta>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.5.0CC: bilwei, cbolz, dajohnso, dclarizi, hkataria, jfrey, jhardy, kmorey, lavenel, mberube, mfeifer, mkanoor, mpovolny, obarenbo, sshveta, tfitzger
Target Milestone: GAKeywords: FutureFeature
Target Release: 5.6.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.6.0.4 Doc Type: Enhancement
Doc Text:
This CloudForms release improves the presentation of stacks in the user interface by allowing user-added orchestration templates to be orderable. Additionally, orchestration templates automatically collected from a provider are no longer displayed under Orchestration Templates. This was not possible in previous versions because the code organized both root and nested stacks in one flat table instead of in a tree structure starting from the provider level.
Story Points: ---
Clone Of: 1298262 Environment:
Last Closed: 2016-06-29 15:34:38 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1298262    
Bug Blocks:    

Comment 2 Bill Wei 2016-01-28 16:53:02 UTC
I am working on the provider refresher code to suppress resource groups from OpenStack being read as nested stacks. As a result no additional heat templates will be added to VMDB.

Comment 3 Bill Wei 2016-02-05 20:03:01 UTC
After more discussions we decide to introduce a new column named orderable to orchestration template table. Templates that are found in provider but not in VMDB will be marked as not-orderable, thus not visible in Service -> Catalogs -> Orchestration Templates.

User added templates through manageiq UI template editor will be visible. Templates that are found in provider but identical to the ones added by user will remain visible too.

Comment 5 CFME Bot 2016-02-12 21:35:36 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/808f553d23d51bf9ed6d9aa9ca1865513437df65

commit 808f553d23d51bf9ed6d9aa9ca1865513437df65
Author:     Bill Wei <bilwei>
AuthorDate: Fri Feb 5 09:19:57 2016 -0500
Commit:     Bill Wei <bilwei>
CommitDate: Thu Feb 11 16:57:21 2016 -0500

    Add orderable column to orchestration_templates
    
    User added templates are default to orderable.
    Auto collected templates from provider are default to non-orderable.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1302810

 app/controllers/catalog_controller.rb              |  6 +-
 .../amazon/cloud_manager/refresh_parser.rb         |  1 +
 .../azure/cloud_manager/refresh_parser.rb          |  3 +-
 .../refresh_parser_common/orchestration_stacks.rb  |  3 +-
 app/models/orchestration_template.rb               | 42 ++++++++--
 ...130_add_orderable_to_orchestration_templates.rb | 15 ++++
 .../amazon/cloud_manager/refresher_spec.rb         |  1 +
 spec/models/orchestration_template_spec.rb         | 92 ++++++++++++++++++----
 8 files changed, 136 insertions(+), 27 deletions(-)
 create mode 100644 db/migrate/20160203101130_add_orderable_to_orchestration_templates.rb

Comment 8 Bill Wei 2016-02-22 15:17:12 UTC
Reassign to UI to complete the rest of the changes.
https://github.com/ManageIQ/manageiq/issues/6600

Comment 10 Milan Zázrivec 2016-04-11 16:17:03 UTC
https://github.com/ManageIQ/manageiq/pull/7822

Comment 11 Shveta 2016-05-04 19:52:30 UTC
Fixed.
Verified in 5.6.0.5-beta2.4.20160503153816_1fb554f 
Orchestration templates are orderable and not visible unless ordered

Comment 13 errata-xmlrpc 2016-06-29 15:34:38 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1348