| Summary: | Change the copyright on all the Windows drivers to "2017" in virtio-win-prewhql build | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | lijin <lijin> | ||||
| Component: | virtio-win | Assignee: | Vadim Rozenfeld <vrozenfe> | ||||
| virtio-win sub component: | virtio-win-prewhql | QA Contact: | Virtualization Bugs <virt-bugs> | ||||
| Status: | CLOSED ERRATA | Docs Contact: | |||||
| Severity: | unspecified | ||||||
| Priority: | unspecified | CC: | lmiksik, peliu, phou, vrozenfe, wyu, yvugenfi | ||||
| Version: | 7.3 | ||||||
| Target Milestone: | rc | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2017-08-01 12:53:08 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Attachments: |
|
||||||
|
Description
lijin
2016-02-01 06:43:47 UTC
Hello, Verified this issue on virtio-win-prewhql-113, the copyright of *.inf,*.sys, License file in build 113 package have been updated to 2016, the issue has been fixed. Thanks~~ Best Regards! Peixiu Hou According comment#2, the bug has been fixed, change the status to verified. Thanks Yu Wang Hi, retest on virtio-win-prewhql-126, all the copyright in netkvm.inf, is 2015 not 2016, should change to 2016. So change the bug to assigned. Thanks Yu Wang Postpone to 7.4 as it's too late for rhel7.3 should be fixed in buld 133 Task Info: https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=12631350 Build Info: https://brewweb.engineering.redhat.com/brew/buildinfo?buildID=540860 Hi Vadim, tried on build 134, some driver's copyright especially for netkvm still not right as below. [ERR].\Wlh\amd64\netkvm.inf: ; Copyright (c) 2008-2015 Red Hat, Inc. All rights reserved. [ERR].\Wlh\x86\netkvm.inf: ; Copyright (c) 2008-2015 Red Hat, Inc. All rights reserved. no copyright in.\qemupciserial.inf no copyright in.\Wnet\amd64\netkvm.inf no copyright in.\Wnet\x86\netkvm.inf no copyright in.\Wxp\x86\netkvm.inf According to the latest document version,https://mojo.redhat.com/docs/DOC-1100497. We need the contents of the path \Wlh when testing netkvm driver in win2008, but the copyright information is not correct. [ERR].\Wlh\amd64\netkvm.inf: ; Copyright (c) 2008-2015 Red Hat, Inc. All rights reserved. [ERR].\Wlh\x86\netkvm.inf: ; Copyright (c) 2008-2015 Red Hat, Inc. All rights Please help to correct it. Thanks & regards Peizhen Liu (In reply to peliu from comment #11) > Hi Vadim, > > tried on build 134, some driver's copyright especially for netkvm still not > right as below. > > [ERR].\Wlh\amd64\netkvm.inf: ; Copyright (c) 2008-2015 Red Hat, Inc. All > rights reserved. > [ERR].\Wlh\x86\netkvm.inf: ; Copyright (c) 2008-2015 Red Hat, Inc. All > rights reserved. > no copyright in.\qemupciserial.inf > no copyright in.\Wnet\amd64\netkvm.inf > no copyright in.\Wnet\x86\netkvm.inf > no copyright in.\Wxp\x86\netkvm.inf > > According to the latest document > version,https://mojo.redhat.com/docs/DOC-1100497. We need the contents of > the path \Wlh when testing netkvm driver in win2008, but the copyright > information is not correct. > [ERR].\Wlh\amd64\netkvm.inf: ; Copyright (c) 2008-2015 Red Hat, Inc. All > rights reserved. > [ERR].\Wlh\x86\netkvm.inf: ; Copyright (c) 2008-2015 Red Hat, Inc. All > rights > Please help to correct it. > > Thanks & regards > Peizhen Liu Thanks a lot. Fixed netkvm problems. The changes should be visible in the next build. But I have some problems with qemupciserial, which is technically derived from .inf fiile provided by Microsoft. Yan, do you think it will be fine to add RH copyright statement into qemupciserial.inf file? Thanks, Vadim. please give a try to build 135 available at http://download.eng.bos.redhat.com/brewroot/packages/virtio-win-prewhql/0.1/135/win/virtio-win-prewhql-0.1.zip Thanks, Vadim. Hi Vadim, tried on build 135, all driver's copyright right. Thanks & regards Peizhen Liu Thank you a lot for the update. Vadim. Created attachment 1272477 [details]
copyright for qemupciserial
It can be a problem. We have to check what to do with this case. mf.sys is an in-box driver provided by Microsoft, and it is properly signed with MS signature. The .cat file is generated by ourselves and signed with RH cross signature. I'm not sure if we can submit that .cat file for WHQL signing. (In reply to Vadim Rozenfeld from comment #19) > It can be a problem. We have to check what to do with this case. > mf.sys is an in-box driver provided by Microsoft, and it is properly signed > with MS signature. The .cat file is generated by ourselves and signed with > RH cross signature. I'm not sure if we can submit that .cat file for WHQL > signing. I have submitted the driver to msft,all get approved. change status to verified according to comment#15 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2017:2341 |