Bug 1303945

Summary:	Memory leak in dht
Product:	[Community] GlusterFS	Reporter:	Vijay Bellur <vbellur>
Component:	distribute	Assignee:	Sakshi <sabansal>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs, nbalacha, rgowdapp, sabansal, smohan
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.8rc2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1304889 (view as bug list)		Environment:
Last Closed:	2016-06-16 13:56:34 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1304889

Description Vijay Bellur 2016-02-02 13:26:53 UTC

Description of problem:

Any rename operation causes a leak in dht. This is due to a dictionary which is not being currently freed in dht_do_rename(). 

Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
1. Perform renames on a fuse/nfs mount point
2. Check the memory usage of fuse client or nfs server


Actual results:
Memory usage increases with more renames being done.

Expected results:
Memory usage should remain stable even with multiple renames.


Additional info:

Comment 1 Vijay Bellur 2016-02-02 14:07:02 UTC

REVIEW: http://review.gluster.org/13322 (cluster/dht: Cleanup dict in dht_do_rename()) posted (#2) for review on master by Vijay Bellur (vbellur)

Comment 2 Vijay Bellur 2016-02-04 08:40:21 UTC

COMMIT: http://review.gluster.org/13322 committed in master by Raghavendra G (rgowdapp) 
------
commit e07fdc4b6d8936089a9ec08aa61f450126b43787
Author: Vijay Bellur <vbellur>
Date:   Fri Jan 29 15:59:24 2016 -0500

    cluster/dht: Cleanup dict in dht_do_rename()
    
    Change-Id: Ib4b3a843e78eccf5b8e0e7776cd0128013a59a3e
    BUG: 1303945
    Signed-off-by: Vijay Bellur <vbellur>
    Reviewed-on: http://review.gluster.org/13322
    CentOS-regression: Gluster Build System <jenkins.com>
    Smoke: Gluster Build System <jenkins.com>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Raghavendra G <rgowdapp>

Comment 3 Sakshi 2016-02-08 06:39:42 UTC

More leaks found in DHT, will be sending patches to fix them.

Comment 4 Vijay Bellur 2016-02-08 06:48:47 UTC

REVIEW: http://review.gluster.org/13392 (dht: cleanup dict and free memory in rename code path) posted (#1) for review on master by Sakshi Bansal

Comment 5 Vijay Bellur 2016-02-15 11:00:09 UTC

REVIEW: http://review.gluster.org/13392 (dht: cleanup dict and free memory in rename code path) posted (#2) for review on master by Sakshi Bansal

Comment 6 Vijay Bellur 2016-02-25 05:11:42 UTC

COMMIT: http://review.gluster.org/13392 committed in master by Raghavendra G (rgowdapp) 
------
commit b7d01547dad88aeebc8cc2dbd68839885615bd66
Author: Sakshi Bansal <sabansal>
Date:   Mon Feb 8 12:14:12 2016 +0530

    dht: cleanup dict and free memory in rename code path
    
    Change-Id: I2458e18197bdf7565563a85e9021b5b2850c1825
    BUG: 1303945
    Signed-off-by: Sakshi Bansal <sabansal>
    Reviewed-on: http://review.gluster.org/13392
    Smoke: Gluster Build System <jenkins.com>
    Reviewed-by: Xavier Hernandez <xhernandez>
    CentOS-regression: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Raghavendra G <rgowdapp>

Comment 7 Niels de Vos 2016-06-16 13:56:34 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user