Bug 1305221

Summary: hydrogen: FTBFS in rawhide
Product: [Fedora] Fedora Reporter: Fedora Release Engineering <releng>
Component: hydrogenAssignee: Brendan Jones <brendan.jones.it>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 24CC: brendan.jones.it, gwync, nando, nphilipp, rc040203, yselkowi
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-11-30 18:23:18 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1305208    
Attachments:
Description Flags
build.log
none
root.log
none
state.log none

Description Fedora Release Engineering 2016-02-06 06:30:32 UTC 
Your package hydrogen failed to build from source in current rawhide.

http://koji.fedoraproject.org/koji/taskinfo?taskID=12801789

For details on mass rebuild see https://fedoraproject.org/wiki/Fedora_24_Mass_Rebuild
Comment 1 Fedora Release Engineering 2016-02-06 06:30:36 UTC 
Created attachment 1121595 [details]
build.log
Comment 2 Fedora Release Engineering 2016-02-06 06:30:38 UTC 
Created attachment 1121596 [details]
root.log
Comment 3 Fedora Release Engineering 2016-02-06 06:30:39 UTC 
Created attachment 1121597 [details]
state.log
Comment 4 Yaakov Selkowitz 2016-02-19 04:30:13 UTC 
libs/hydrogen/src/local_file_mgr.cpp: In member function 'int H2Core::LocalFileMng::loadPlayList(const string&)':
libs/hydrogen/src/local_file_mgr.cpp:983:14: error: no match for 'operator==' (operand types are 'std::ifstream {aka std::basic_ifstream<char>}' and 'long int')
  if ( verify == NULL ) {
       ~~~~~~~^~~~

This looks like "Cannot convert 'std::ostream' to 'bool'" in https://gcc.gnu.org/gcc-6/porting_to.html
Comment 5 Jan Kurik 2016-02-24 14:25:28 UTC 
This bug appears to have been reported against 'rawhide' during the Fedora 24 development cycle.
Changing version to '24'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora24#Rawhide_Rebase
Comment 6 Ralf Corsepius 2016-03-22 10:30:18 UTC 
IMO, this patch should fix this FTBFS:

# diff -Naur hydrogen-0.9.5.1.orig/libs/hydrogen/src/local_file_mgr.cpp hydrogen-0.9.5.1/libs/hydrogen/src/local_file_mgr.cpp
--- hydrogen-0.9.5.1.orig/libs/hydrogen/src/local_file_mgr.cpp  2011-01-29 00:33:23.000000000 +0100
+++ hydrogen-0.9.5.1/libs/hydrogen/src/local_file_mgr.cpp       2016-03-22 11:18:00.165112624 +0100
@@ -980,7 +980,7 @@

        std::string playlistInfoFile = patternname;
        std::ifstream verify( playlistInfoFile.c_str() , std::ios::in | std::ios::binary );
-       if ( verify == NULL ) {
+       if ( !verify ) {
                //ERRORLOG( "Load Playlist: Data file " + playlistInfoFile + " not found." );
                return NULL;
        }