Bug 1305221 - hydrogen: FTBFS in rawhide
Summary: hydrogen: FTBFS in rawhide
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: hydrogen
Version: 24
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Brendan Jones
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F24FTBFS
TreeView+ depends on / blocked
 
Reported: 2016-02-06 06:30 UTC by Fedora Release Engineering
Modified: 2016-11-30 18:23 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2016-11-30 18:23:18 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
build.log (203.55 KB, text/plain)
2016-02-06 06:30 UTC, Fedora Release Engineering
no flags Details
root.log (110.49 KB, text/plain)
2016-02-06 06:30 UTC, Fedora Release Engineering
no flags Details
state.log (637 bytes, text/plain)
2016-02-06 06:30 UTC, Fedora Release Engineering
no flags Details

Description Fedora Release Engineering 2016-02-06 06:30:32 UTC
Your package hydrogen failed to build from source in current rawhide.

http://koji.fedoraproject.org/koji/taskinfo?taskID=12801789

For details on mass rebuild see https://fedoraproject.org/wiki/Fedora_24_Mass_Rebuild

Comment 1 Fedora Release Engineering 2016-02-06 06:30:36 UTC
Created attachment 1121595 [details]
build.log

Comment 2 Fedora Release Engineering 2016-02-06 06:30:38 UTC
Created attachment 1121596 [details]
root.log

Comment 3 Fedora Release Engineering 2016-02-06 06:30:39 UTC
Created attachment 1121597 [details]
state.log

Comment 4 Yaakov Selkowitz 2016-02-19 04:30:13 UTC
libs/hydrogen/src/local_file_mgr.cpp: In member function 'int H2Core::LocalFileMng::loadPlayList(const string&)':
libs/hydrogen/src/local_file_mgr.cpp:983:14: error: no match for 'operator==' (operand types are 'std::ifstream {aka std::basic_ifstream<char>}' and 'long int')
  if ( verify == NULL ) {
       ~~~~~~~^~~~

This looks like "Cannot convert 'std::ostream' to 'bool'" in https://gcc.gnu.org/gcc-6/porting_to.html

Comment 5 Jan Kurik 2016-02-24 14:25:28 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 24 development cycle.
Changing version to '24'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora24#Rawhide_Rebase

Comment 6 Ralf Corsepius 2016-03-22 10:30:18 UTC
IMO, this patch should fix this FTBFS:

# diff -Naur hydrogen-0.9.5.1.orig/libs/hydrogen/src/local_file_mgr.cpp hydrogen-0.9.5.1/libs/hydrogen/src/local_file_mgr.cpp
--- hydrogen-0.9.5.1.orig/libs/hydrogen/src/local_file_mgr.cpp  2011-01-29 00:33:23.000000000 +0100
+++ hydrogen-0.9.5.1/libs/hydrogen/src/local_file_mgr.cpp       2016-03-22 11:18:00.165112624 +0100
@@ -980,7 +980,7 @@

        std::string playlistInfoFile = patternname;
        std::ifstream verify( playlistInfoFile.c_str() , std::ios::in | std::ios::binary );
-       if ( verify == NULL ) {
+       if ( !verify ) {
                //ERRORLOG( "Load Playlist: Data file " + playlistInfoFile + " not found." );
                return NULL;
        }


Note You need to log in before you can comment on or make changes to this bug.