Bug 1305263
| Summary: | Review Request: perl-Text-Fuzzy - Partial string matching using edit distances | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Denis Fateyev <denis> |
| Component: | Package Review | Assignee: | Petr Šabata <psabata> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, perl-devel, psabata |
| Target Milestone: | --- | Flags: | psabata:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-02-26 19:24:14 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Denis Fateyev
2016-02-06 14:17:46 UTC
* Missing builddeps: gcc, perl-devel
* I'm not sure $LDFLAGS contains anything; consider using %{?__global_ldflags}.
* Consider packaging the examples directory as %doc.
* Again, you could drop the coreutils build dep if you modify the find calls.
* And again, this module also technically requires Test::More 0.88+. Don't
worry about it; I'm just mentioning it for completeness :)
dfateyev's scratch build of perl-Text-Fuzzy-0.24-2.fc23.denf.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12903164 (In reply to Petr Šabata from comment #1) > * Missing builddeps: gcc, perl-devel Added. > * I'm not sure $LDFLAGS contains anything; consider using > %{?__global_ldflags}. In RHEL7 it contains not much though: # rpm -E '%{?__global_ldflags}' -Wl,-z,relro Although the changed version should fit everything: export LDFLAGS="%{?__global_ldflags} -Wl,-z,now -Wl,--as-needed" > * Consider packaging the examples directory as %doc. Added. > * And again, this module also technically requires Test::More 0.88+. Don't > worry about it; I'm just mentioning it for completeness :) Well, since epel7 has 0.98 (and Fedoras even newer) I initially dropped it; but returned back for now. Updated version: Spec: http://www.fateyev.com/RPMS/Fedora22/perl-Text-Fuzzy.spec SRPM: http://www.fateyev.com/RPMS/Fedora22/perl-Text-Fuzzy-0.24-2.fc24.src.rpm Almost there :) * Some of the example scripts are executable. chmod a-x -c examples/*pl * rpmlint complains about the script interpreter for them, too. perl -pi -e 's|#!.*$|#!/usr/bin/perl|' examples/*pl I'm going to approve this review now but, please, fix these before building the package. Ok, will do. Thanks for the review. dfateyev's scratch build of perl-Text-Fuzzy-0.24-2.fc23.denf.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12903941 Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/perl-Text-Fuzzy perl-Text-Fuzzy-0.24-3.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-ec71a6aa0c perl-Text-Fuzzy-0.24-3.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-b9b25e2bf4 perl-Text-Fuzzy-0.24-3.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-ec71a6aa0c perl-Text-Fuzzy-0.24-3.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-ec71a6aa0c perl-Text-Fuzzy-0.24-3.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-ec71a6aa0c perl-Text-Fuzzy-0.24-3.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-b9b25e2bf4 perl-Text-Fuzzy-0.24-3.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-ec71a6aa0c perl-Text-Fuzzy-0.24-3.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. perl-Text-Fuzzy-0.24-3.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. |