Spec URL: http://www.fateyev.com/RPMS/Fedora22/perl-Text-Fuzzy.spec SRPM URL: http://www.fateyev.com/RPMS/Fedora22/perl-Text-Fuzzy-0.24-1.fc24.src.rpm Description: This module calculates edit distances between words, and searches arrays and files to find the nearest entry by edit distance. It handles both byte strings and character strings (strings containing Unicode), treating each Unicode character as a single entity. Fedora Account System Username: dfateyev Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=12895359 (Rawhide) Also planned to provide in epel7 in the future.
* Missing builddeps: gcc, perl-devel * I'm not sure $LDFLAGS contains anything; consider using %{?__global_ldflags}. * Consider packaging the examples directory as %doc. * Again, you could drop the coreutils build dep if you modify the find calls. * And again, this module also technically requires Test::More 0.88+. Don't worry about it; I'm just mentioning it for completeness :)
dfateyev's scratch build of perl-Text-Fuzzy-0.24-2.fc23.denf.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12903164
(In reply to Petr Šabata from comment #1) > * Missing builddeps: gcc, perl-devel Added. > * I'm not sure $LDFLAGS contains anything; consider using > %{?__global_ldflags}. In RHEL7 it contains not much though: # rpm -E '%{?__global_ldflags}' -Wl,-z,relro Although the changed version should fit everything: export LDFLAGS="%{?__global_ldflags} -Wl,-z,now -Wl,--as-needed" > * Consider packaging the examples directory as %doc. Added. > * And again, this module also technically requires Test::More 0.88+. Don't > worry about it; I'm just mentioning it for completeness :) Well, since epel7 has 0.98 (and Fedoras even newer) I initially dropped it; but returned back for now. Updated version: Spec: http://www.fateyev.com/RPMS/Fedora22/perl-Text-Fuzzy.spec SRPM: http://www.fateyev.com/RPMS/Fedora22/perl-Text-Fuzzy-0.24-2.fc24.src.rpm
Almost there :) * Some of the example scripts are executable. chmod a-x -c examples/*pl * rpmlint complains about the script interpreter for them, too. perl -pi -e 's|#!.*$|#!/usr/bin/perl|' examples/*pl I'm going to approve this review now but, please, fix these before building the package.
Ok, will do. Thanks for the review.
dfateyev's scratch build of perl-Text-Fuzzy-0.24-2.fc23.denf.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12903941
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/perl-Text-Fuzzy
perl-Text-Fuzzy-0.24-3.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-ec71a6aa0c
perl-Text-Fuzzy-0.24-3.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-b9b25e2bf4
perl-Text-Fuzzy-0.24-3.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-b9b25e2bf4
perl-Text-Fuzzy-0.24-3.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-ec71a6aa0c
perl-Text-Fuzzy-0.24-3.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
perl-Text-Fuzzy-0.24-3.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.