Bug 1305294
| Summary: | Review Request: perl-Parse-Gitignore - Parse .gitignore files | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Denis Fateyev <denis> |
| Component: | Package Review | Assignee: | Petr Šabata <psabata> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, perl-devel, psabata |
| Target Milestone: | --- | Flags: | psabata:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-02-26 19:24:19 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Denis Fateyev
2016-02-06 19:29:50 UTC
* You could drop the findutils builddep by substituting `-exec rm -f {} \;'
with `-delete'.
* The actual required version of Test::More is 0.88 (as done_testing is called).
That's just nitpicking; upstream doesn't declare it either :)
* Require the versioned Path::Tiny and filter out the underspecified
autogenerated dependency.
(In reply to Petr Šabata from comment #1) > * You could drop the findutils builddep by substituting `-exec rm -f {} \;' > with `-delete'. Erm, coreutils, of course. dfateyev's scratch build of perl-Parse-Gitignore-0.02-2.fc23.denf.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12903416 (In reply to Petr Šabata from comment #1) > * You could drop the findutils builddep by substituting `-exec rm -f {} \;' > with `-delete'. I just keeping it for a while for package spec uniformity.. Seems, I need to adjust and improve my Perl spec template. > * The actual required version of Test::More is 0.88 (as done_testing is > called). > That's just nitpicking; upstream doesn't declare it either :) Added. (the same comment applied here) > * Require the versioned Path::Tiny and filter out the underspecified > autogenerated dependency. Added. (also shouldn't be a problem with RHBZ bug 1305293) Updated version: Spec: http://www.fateyev.com/RPMS/Fedora22/perl-Parse-Gitignore.spec SRPM: http://www.fateyev.com/RPMS/Fedora22/perl-Parse-Gitignore-0.02-1.fc24.src.rpm All good. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/perl-Parse-Gitignore perl-Parse-Gitignore-0.02-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-8bb99cd844 perl-Parse-Gitignore-0.02-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-736f884ebc perl-Parse-Gitignore-0.02-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-8bb99cd844 perl-Parse-Gitignore-0.02-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-8bb99cd844 perl-Parse-Gitignore-0.02-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-736f884ebc perl-Parse-Gitignore-0.02-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. perl-Parse-Gitignore-0.02-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. |