Bug 1305294 - Review Request: perl-Parse-Gitignore - Parse .gitignore files
Summary: Review Request: perl-Parse-Gitignore - Parse .gitignore files
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Šabata
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-02-06 19:29 UTC by Denis Fateyev
Modified: 2016-03-07 02:56 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-02-26 19:24:19 UTC
psabata: fedora-review+


Attachments (Terms of Use)

Description Denis Fateyev 2016-02-06 19:29:50 UTC
Spec URL: http://www.fateyev.com/RPMS/Fedora22/perl-Parse-Gitignore.spec
SRPM URL: http://www.fateyev.com/RPMS/Fedora22/perl-Parse-Gitignore-0.02-1.fc24.src.rpm
Description: Parse a .gitignore file and check whether a file matches it.
Fedora Account System Username: dfateyev

Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=12895982 (Rawhide)

Comment 1 Petr Šabata 2016-02-08 10:01:05 UTC
* You could drop the findutils builddep by substituting `-exec rm -f {} \;'
  with `-delete'.

* The actual required version of Test::More is 0.88 (as done_testing is called).
  That's just nitpicking; upstream doesn't declare it either :)

* Require the versioned Path::Tiny and filter out the underspecified
  autogenerated dependency.

Comment 2 Petr Šabata 2016-02-08 11:12:13 UTC
(In reply to Petr Šabata from comment #1)
> * You could drop the findutils builddep by substituting `-exec rm -f {} \;'
>   with `-delete'.

Erm, coreutils, of course.

Comment 3 Upstream Release Monitoring 2016-02-08 15:48:34 UTC
dfateyev's scratch build of perl-Parse-Gitignore-0.02-2.fc23.denf.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12903416

Comment 4 Denis Fateyev 2016-02-08 16:01:44 UTC
(In reply to Petr Šabata from comment #1)
> * You could drop the findutils builddep by substituting `-exec rm -f {} \;'
>   with `-delete'.

I just keeping it for a while for package spec uniformity..
Seems, I need to adjust and improve my Perl spec template.

> * The actual required version of Test::More is 0.88 (as done_testing is
> called).
>   That's just nitpicking; upstream doesn't declare it either :)

Added. (the same comment applied here)

> * Require the versioned Path::Tiny and filter out the underspecified
>   autogenerated dependency.

Added. (also shouldn't be a problem with RHBZ bug 1305293)

Updated version:
Spec: http://www.fateyev.com/RPMS/Fedora22/perl-Parse-Gitignore.spec
SRPM: http://www.fateyev.com/RPMS/Fedora22/perl-Parse-Gitignore-0.02-1.fc24.src.rpm

Comment 5 Petr Šabata 2016-02-08 16:19:27 UTC
All good.

Comment 6 Gwyn Ciesla 2016-02-09 17:20:59 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/perl-Parse-Gitignore

Comment 7 Fedora Update System 2016-02-17 10:52:09 UTC
perl-Parse-Gitignore-0.02-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-8bb99cd844

Comment 8 Fedora Update System 2016-02-17 10:52:10 UTC
perl-Parse-Gitignore-0.02-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-736f884ebc

Comment 9 Fedora Update System 2016-02-17 10:52:13 UTC
perl-Parse-Gitignore-0.02-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-8bb99cd844

Comment 10 Fedora Update System 2016-02-17 22:31:30 UTC
perl-Parse-Gitignore-0.02-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-8bb99cd844

Comment 11 Fedora Update System 2016-02-21 06:21:50 UTC
perl-Parse-Gitignore-0.02-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-736f884ebc

Comment 12 Fedora Update System 2016-02-26 19:24:16 UTC
perl-Parse-Gitignore-0.02-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2016-03-07 02:56:41 UTC
perl-Parse-Gitignore-0.02-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.