Bug 1306308
| Summary: | RSS feeds for datastore alerts has incorrect title 'VM:' | ||
|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Vadim Rutkovsky <vrutkovs> |
| Component: | Control | Assignee: | Lucy Fu <lufu> |
| Status: | CLOSED ERRATA | QA Contact: | Dmitry Misharov <dmisharo> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 5.5.0 | CC: | cpelland, jhardy, jprause, mfeifer, nachandr, obarenbo |
| Target Milestone: | GA | ||
| Target Release: | 5.6.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | control:alert | ||
| Fixed In Version: | 5.6.0.1 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-06-29 15:37:08 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Vadim Rutkovsky
2016-02-10 14:23:02 UTC
New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/f55b7855183b89f4ee119a7c266151d02cb5bda9 commit f55b7855183b89f4ee119a7c266151d02cb5bda9 Author: Lucy Fu <lufu> AuthorDate: Tue Mar 1 15:11:55 2016 -0500 Commit: Lucy Fu <lufu> CommitDate: Tue Mar 15 11:34:00 2016 -0400 MiqAction#action_evm_event should raise MiqEvent instead of EmsEvent. Usually EmsEvent is used for provider events and MiqEvent is used for MIQ events. Keep the fields in MiqEvent for EVMAlertEvent. These fields are checked by event_where_clause. Alert can be set based on Datastores. But EmsEvent does not have a field for datastore. https://bugzilla.redhat.com/show_bug.cgi?id=1306308 app/models/miq_action.rb | 3 ++- spec/models/miq_action_spec.rb | 31 ++++++++++++++++++++----------- 2 files changed, 22 insertions(+), 12 deletions(-) New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/5b1183c2e0995687475f5e40b7260eac4ee0042d commit 5b1183c2e0995687475f5e40b7260eac4ee0042d Author: Lucy Fu <lufu> AuthorDate: Tue Mar 1 15:13:24 2016 -0500 Commit: Lucy Fu <lufu> CommitDate: Tue Mar 15 11:34:00 2016 -0400 Change Alert related RSS feeds to look at MiqEvent instead of EmsEvent. https://bugzilla.redhat.com/show_bug.cgi?id=1306308 product/alerts/rss/all_alert_event.yml | 21 ++++++++------------- product/alerts/rss/cluster_alert_event.yml | 22 +++++++++++----------- product/alerts/rss/host_alert_event.yml | 22 +++++++++++----------- product/alerts/rss/vm_alert_event.yml | 22 +++++++++++----------- 4 files changed, 41 insertions(+), 46 deletions(-) New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/50085ffdbdb9e282dc980d83040399bed6670ffe commit 50085ffdbdb9e282dc980d83040399bed6670ffe Author: Lucy Fu <lufu> AuthorDate: Tue Mar 15 10:01:02 2016 -0400 Commit: Lucy Fu <lufu> CommitDate: Tue Mar 15 11:34:43 2016 -0400 Let Timeline check EventStream class. So Timeline can get both EmsEvent and MiqEvent for EVMAlertEvent. https://bugzilla.redhat.com/show_bug.cgi?id=1306308 app/controllers/application_controller/timelines.rb | 4 ++-- app/models/container.rb | 2 +- app/models/container_group.rb | 2 +- app/models/container_node.rb | 2 +- app/models/container_project.rb | 2 +- app/models/container_replicator.rb | 2 +- app/models/host.rb | 2 +- app/models/vm_or_template.rb | 2 +- 8 files changed, 9 insertions(+), 9 deletions(-) New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/2f400dd157cf3302627dbbbf0477102dc001bfe8 commit 2f400dd157cf3302627dbbbf0477102dc001bfe8 Author: Lucy Fu <lufu> AuthorDate: Tue Mar 15 10:08:49 2016 -0400 Commit: Lucy Fu <lufu> CommitDate: Tue Mar 15 11:34:53 2016 -0400 Timeline needs the event timestamp to sort the events. MiqEvent of EVMAlertEvent is checked by Timeline. https://bugzilla.redhat.com/show_bug.cgi?id=1306308 app/models/miq_event.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/1a0ca0cd6cb497e68d133747ba5b62df34fa1e23 commit 1a0ca0cd6cb497e68d133747ba5b62df34fa1e23 Author: Lucy Fu <lufu> AuthorDate: Tue Mar 15 10:59:31 2016 -0400 Commit: Lucy Fu <lufu> CommitDate: Tue Mar 15 12:05:35 2016 -0400 Add migration to convert EVMAlertEvent from EmsEvent to MiqEvent. https://bugzilla.redhat.com/show_bug.cgi?id=1306308 ...07205816_fix_event_class_for_evm_alert_event.rb | 53 +++++++ ...816_fix_event_class_for_evm_alert_event_spec.rb | 161 +++++++++++++++++++++ 2 files changed, 214 insertions(+) create mode 100644 db/migrate/20160307205816_fix_event_class_for_evm_alert_event.rb create mode 100644 spec/migrations/20160307205816_fix_event_class_for_evm_alert_event_spec.rb Verified fixed in 5.6.0.1-beta2.20160413141124_e25ac0e. RSS feeds for datastore have proper name and working links. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2016:1348 |