Bug 1306321

Summary: Error:undefined method `>' for nil:NilClass [miq_policy/rsop] when clicked on submit button in Control->simulation
Product: Red Hat CloudForms Management Engine Reporter: Chris Pelland <cpelland>
Component: UI - OPSAssignee: Harpreet Kataria <hkataria>
Status: CLOSED ERRATA QA Contact: Taras Lehinevych <tlehinev>
Severity: medium Docs Contact:
Priority: high    
Version: 5.5.0CC: akarol, cpelland, dajohnso, hkataria, jhardy, jprause, mfeifer, mpovolny, obarenbo
Target Milestone: GAKeywords: ZStream
Target Release: 5.5.3   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: error
Fixed In Version: 5.5.3.2 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1304288 Environment:
Last Closed: 2016-04-13 18:43:01 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1304288    
Bug Blocks:    

Comment 2 CFME Bot 2016-02-11 16:03:14 UTC
New commit detected on cfme/5.5.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=417511ff39e82e2364f15c72c1b8c4ce21c4303a

commit 417511ff39e82e2364f15c72c1b8c4ce21c4303a
Merge: c5da485 214a7fe
Author:     Dan Clarizio <dclarizi>
AuthorDate: Thu Feb 11 10:54:21 2016 -0500
Commit:     Dan Clarizio <dclarizi>
CommitDate: Thu Feb 11 10:54:21 2016 -0500

    Merge branch '55z_pr_6559' into '5.5.z'
    
    reset session[:changed] first time on Control/Simulation screen
    
    when coming from another screen sometimes session[:changed] was still set to true causing "Submit" button to be enabled when going to Control/Simulation screen first time causing it to blow up if user pressed submit button without making selections in the form.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1304288
    https://bugzilla.redhat.com/show_bug.cgi?id=1306321
    (cherry picked from commit ed5a343)
    
    @dclarizi please review, clean cherry-pick for https://github.com/ManageIQ/manageiq/pull/6559
    
    See merge request !776

 app/controllers/miq_policy_controller/rsop.rb      |  1 +
 .../controllers/miq_policy_controller/rsop_spec.rb | 28 ++++++++++++++++++++++
 2 files changed, 29 insertions(+)

Comment 3 CFME Bot 2016-02-11 16:03:43 UTC
New commit detected on cfme/5.5.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=214a7fe25568f3da3a20bd5173797dc724217130

commit 214a7fe25568f3da3a20bd5173797dc724217130
Author:     Harpreet Kataria <hkataria>
AuthorDate: Mon Feb 8 17:20:10 2016 -0500
Commit:     Harpreet Kataria <hkataria>
CommitDate: Wed Feb 10 14:15:33 2016 -0500

    reset session[:changed] first time on Control/Simulation screen
    
    when coming from another screen sometimes session[:changed] was still set to true causing "Submit" button to be enabled when going to Control/Simulation screen first time causing it to blow up if user pressed submit button without making selections in the form.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1304288
    https://bugzilla.redhat.com/show_bug.cgi?id=1306321
    (cherry picked from commit ed5a343)

 app/controllers/miq_policy_controller/rsop.rb      |  1 +
 .../controllers/miq_policy_controller/rsop_spec.rb | 28 ++++++++++++++++++++++
 2 files changed, 29 insertions(+)
 create mode 100644 spec/controllers/miq_policy_controller/rsop_spec.rb

Comment 5 Taras Lehinevych 2016-03-28 09:31:12 UTC
Verified in 5.5.3.2

Comment 7 errata-xmlrpc 2016-04-13 18:43:01 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:0616