Bug 1306413
| Summary: | [abrt] nano: main(): nano killed by SIGSEGV | ||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Don Swaner <greatauk37> | ||||||||||||||||||||||||||
| Component: | nano | Assignee: | Kamil Dudka <kdudka> | ||||||||||||||||||||||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||||||||||||||||||||
| Severity: | unspecified | Docs Contact: | |||||||||||||||||||||||||||
| Priority: | unspecified | ||||||||||||||||||||||||||||
| Version: | 23 | CC: | dwmw2, jaswinder, kdudka | ||||||||||||||||||||||||||
| Target Milestone: | --- | Keywords: | Patch | ||||||||||||||||||||||||||
| Target Release: | --- | ||||||||||||||||||||||||||||
| Hardware: | x86_64 | ||||||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||||||
| URL: | https://retrace.fedoraproject.org/faf/reports/bthash/b226e0193991e9f79830a127d8d38f8a469582b9 | ||||||||||||||||||||||||||||
| Whiteboard: | abrt_hash:38d229b90d39107ef3fccc8aa4f670ba58f93a16; | ||||||||||||||||||||||||||||
| Fixed In Version: | nano-2.4.2-3.fc23 | Doc Type: | Bug Fix | ||||||||||||||||||||||||||
| Doc Text: | Story Points: | --- | |||||||||||||||||||||||||||
| Clone Of: | Environment: | ||||||||||||||||||||||||||||
| Last Closed: | 2016-02-17 03:50:55 UTC | Type: | --- | ||||||||||||||||||||||||||
| Regression: | --- | Mount Type: | --- | ||||||||||||||||||||||||||
| Documentation: | --- | CRM: | |||||||||||||||||||||||||||
| Verified Versions: | Category: | --- | |||||||||||||||||||||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||||||||||||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||||||||||||||||||||
| Embargoed: | |||||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||||
|
Description
Don Swaner
2016-02-10 19:01:51 UTC
Created attachment 1122875 [details]
File: backtrace
Created attachment 1122876 [details]
File: cgroup
Created attachment 1122877 [details]
File: core_backtrace
Created attachment 1122878 [details]
File: dso_list
Created attachment 1122879 [details]
File: environ
Created attachment 1122880 [details]
File: exploitable
Created attachment 1122881 [details]
File: limits
Created attachment 1122882 [details]
File: maps
Created attachment 1122883 [details]
File: mountinfo
Created attachment 1122884 [details]
File: open_fds
Created attachment 1122885 [details]
File: proc_pid_status
Created attachment 1122886 [details]
File: var_log_messages
*** Bug 1306272 has been marked as a duplicate of this bug. *** The backtrace does not make any sense to me. Are you sure you have up2date debuginfo packages installed? 5 or 8 new packages were automatically installed today during the reporting of this bug (1306413), so I assume the debuginfo is current. If there is some additional check I need to do to insure it is current, I don't know how to do that. The backtrace is actually correct although it contains only the main() frame. Sorry for not recognizing it previously! The following patch will fix it:
--- a/src/nano.c
+++ b/src/nano.c
@@ -520,15 +520,12 @@ openfilestruct *make_new_opennode(void)
openfilestruct *newnode =
(openfilestruct *)nmalloc(sizeof(openfilestruct));
- newnode->filename = NULL;
- newnode->fileage = NULL;
- newnode->filebot = NULL;
- newnode->edittop = NULL;
- newnode->current = NULL;
+ /* make sure that everything is initialized instead of open-coding
+ * NULL assignments that compilers do not check for completeness */
+ memset(newnode, 0, sizeof *newnode);
+
#ifndef NANO_TINY
- newnode->current_stat = NULL;
newnode->last_action = OTHER;
- newnode->lock_filename = NULL;
#endif
return newnode;
pushed to the f23 branch dist-git: http://pkgs.fedoraproject.org/cgit/rpms/nano.git/commit/?id=798e2b0d nano-2.4.2-3.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-7cad63cca8 The bug occurred when nano was executed in a MATE terminal with monospace 12 font size. If I "zoom out" so that the font size is smaller, then the bug does not occur. Could you please re-test it with nano-2.4.2-3.fc23? http://koji.fedoraproject.org/koji/buildinfo?buildID=734964 nano-2.4.2-3.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-7cad63cca8 nano-2.4.2-3.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. |