Bug 1306738

Summary:	gluster volume heal info takes extra 2 seconds
Product:	[Community] GlusterFS	Reporter:	Pranith Kumar K <pkarampu>
Component:	replicate	Assignee:	Pranith Kumar K <pkarampu>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.7.7	CC:	bugs, sabose
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.9	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1306199	Environment:
Last Closed:	2016-04-19 07:25:49 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1258386

Description Pranith Kumar K 2016-02-11 17:06:51 UTC

+++ This bug was initially created as a clone of Bug #1306199 +++

Description of problem:
This is a code review bug, where there is a 2 second sleep in the code which is un-necessary.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Vijay Bellur on 2016-02-10 05:09:55 EST ---

REVIEW: http://review.gluster.org/13421 (heal: Remove sleep()) posted (#1) for review on master by Pranith Kumar Karampuri (pkarampu)

--- Additional comment from Vijay Bellur on 2016-02-10 21:25:21 EST ---

REVIEW: http://review.gluster.org/13421 (heal: Remove sleep()) posted (#2) for review on master by Pranith Kumar Karampuri (pkarampu)

--- Additional comment from Vijay Bellur on 2016-02-11 12:05:51 EST ---

COMMIT: http://review.gluster.org/13421 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit 320779d53ae013147d5e2556d2946c73e45734ab
Author: Pranith Kumar K <pkarampu>
Date:   Wed Feb 10 15:28:39 2016 +0530

    heal: Remove sleep()
    
    I wrote this program from a sample gfapi program which had sleep.
    I am not sure why this sleep was needed. So removing it now.
    
    Changed tests/bugs/replicate/bug-1190069-afr-stale-index-entries.t
    to execute count_sh_entries every second, instead of comparing
    same value over and over.
    
    Change-Id: I7b89d6cab3e50bb7bf4d40a6064f2d8734155bea
    BUG: 1306199
    Signed-off-by: Pranith Kumar K <pkarampu>
    Reviewed-on: http://review.gluster.org/13421
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Krutika Dhananjay <kdhananj>

Comment 1 Vijay Bellur 2016-02-11 17:10:38 UTC

REVIEW: http://review.gluster.org/13431 (heal: Remove sleep()) posted (#1) for review on release-3.7 by Pranith Kumar Karampuri (pkarampu)

Comment 2 Vijay Bellur 2016-02-12 04:00:13 UTC

COMMIT: http://review.gluster.org/13431 committed in release-3.7 by Pranith Kumar Karampuri (pkarampu) 
------
commit 059710ad62d828d40760c9c63a109286e5e5dca3
Author: Pranith Kumar K <pkarampu>
Date:   Wed Feb 10 15:28:39 2016 +0530

    heal: Remove sleep()
    
    I wrote this program from a sample gfapi program which had sleep.
    I am not sure why this sleep was needed. So removing it now.
    
    Changed tests/bugs/replicate/bug-1190069-afr-stale-index-entries.t
    to execute count_sh_entries every second, instead of comparing
    same value over and over.
    
     >Change-Id: I7b89d6cab3e50bb7bf4d40a6064f2d8734155bea
     >BUG: 1306199
     >Signed-off-by: Pranith Kumar K <pkarampu>
     >Reviewed-on: http://review.gluster.org/13421
     >Smoke: Gluster Build System <jenkins.com>
     >NetBSD-regression: NetBSD Build System <jenkins.org>
     >CentOS-regression: Gluster Build System <jenkins.com>
     >Reviewed-by: Krutika Dhananjay <kdhananj>
     >(cherry picked from commit 320779d53ae013147d5e2556d2946c73e45734ab)
    
    Change-Id: Ia98bb4b35b0e778d777705a03b2415f2093863f7
    BUG: 1306738
    Signed-off-by: Pranith Kumar K <pkarampu>
    Reviewed-on: http://review.gluster.org/13431
    Smoke: Gluster Build System <jenkins.com>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Krutika Dhananjay <kdhananj>
    NetBSD-regression: NetBSD Build System <jenkins.org>

Comment 3 Kaushal 2016-04-19 07:25:49 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.9, please open a new bug report.

glusterfs-3.7.9 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://www.gluster.org/pipermail/gluster-users/2016-March/025922.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user