Bug 1307137

Summary: nodejs-bluebird RPM content does not match NPM module
Product: [Fedora] Fedora EPEL Reporter: Jordan Reuter <jordan.reuter>
Component: nodejs-bluebirdAssignee: Piotr Popieluch <piotr1212>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: unspecified    
Version: epel7CC: nodejs-sig, piotr1212, rbean
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: nodejs-bluebird-2.3.11-1.el7 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-03-02 20:01:20 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jordan Reuter 2016-02-12 19:13:55 UTC
Description of problem:
Attempting to install this package via yum installs the wrong files. I expect the contents of the RPM to be similar, if not identical to the contents of the corresponding NPM package.

Version-Release number of selected component (if applicable):
2.2.2-1.el7

How reproducible:
always

Steps to Reproduce:
1. Install this package with `yum install nodejs-bluebird`
2. At a node shell, type `require('bluebird');`

Actual results:
NodeJS exits after this fatal error:

Error: Cannot find module 'bluebird'

Expected results:
NodeJS successfully `require()`s the module.

Additional info:

It seems as though the wrong files have been bundled into the RPM.
Directory structure after package installation (note presence of zalgo.js):

/lib/node_modules/bluebird/
├── node_modules
├── package.json
└── zalgo.js

After removing the yum package and reinstalling globally with `npm -g i bluebird.2`, this is the directory structure:
/lib/node_modules/bluebird/
├── js
│   ├── main
│   │   ├── any.js
│   │   ├── assert.js
│   │   ├── async.js
│   │   ├── bluebird.js
│   │   ├── call_get.js
│   │   ├── cancel.js
│   │   ├── captured_trace.js
│   │   ├── catch_filter.js
│   │   ├── direct_resolve.js
│   │   ├── each.js
│   │   ├── errors_api_rejection.js
│   │   ├── errors.js
│   │   ├── es5.js
│   │   ├── filter.js
│   │   ├── finally.js
│   │   ├── generators.js
│   │   ├── join.js
│   │   ├── map.js
│   │   ├── nodeify.js
│   │   ├── progress.js
│   │   ├── promise_array.js
│   │   ├── promise.js
│   │   ├── promise_resolver.js
│   │   ├── promisify.js
│   │   ├── props.js
│   │   ├── queue.js
│   │   ├── race.js
│   │   ├── reduce.js
│   │   ├── schedule.js
│   │   ├── settle.js
│   │   ├── some.js
│   │   ├── synchronous_inspection.js
│   │   ├── thenables.js
│   │   ├── timers.js
│   │   ├── using.js
│   │   └── util.js
│   └── zalgo
│       ├── any.js
│       ├── assert.js
│       ├── async.js
│       ├── bluebird.js
│       ├── call_get.js
│       ├── cancel.js
│       ├── captured_trace.js
│       ├── catch_filter.js
│       ├── direct_resolve.js
│       ├── each.js
│       ├── errors_api_rejection.js
│       ├── errors.js
│       ├── es5.js
│       ├── filter.js
│       ├── finally.js
│       ├── generators.js
│       ├── join.js
│       ├── map.js
│       ├── nodeify.js
│       ├── progress.js
│       ├── promise_array.js
│       ├── promise.js
│       ├── promise_resolver.js
│       ├── promisify.js
│       ├── props.js
│       ├── queue.js
│       ├── race.js
│       ├── reduce.js
│       ├── schedule.js
│       ├── settle.js
│       ├── some.js
│       ├── synchronous_inspection.js
│       ├── thenables.js
│       ├── timers.js
│       ├── using.js
│       └── util.js
├── LICENSE
├── package.json
├── README.md
└── zalgo.js

Comment 1 Piotr Popieluch 2016-02-13 12:06:22 UTC
Looks like this is fixed in 2.3 version which is commited to the epel7 branch but was not yet built.

I just built it, seems all deps are fine. 

Ralph, OK if I push the update 2.3 to epel7?

Comment 2 Fedora Update System 2016-02-15 14:32:26 UTC
nodejs-bluebird-2.3.11-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-9b67518519

Comment 3 Fedora Update System 2016-02-17 04:49:53 UTC
nodejs-bluebird-2.3.11-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-9b67518519

Comment 4 Fedora Update System 2016-03-02 20:01:17 UTC
nodejs-bluebird-2.3.11-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.