Bug 1307149
Summary: | Review Request: mkdocs-material - A material design theme for MkDocs | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | William Moreno <williamjmorenor> |
Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | package-review, rdieter |
Target Milestone: | --- | Flags: | rdieter:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2016-05-20 17:42:25 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
William Moreno
2016-02-12 20:33:43 UTC
I can review this Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=13566708 naming: ok sources: ok (mostly) 4d0a704ab73d2c4dafc313ec313362ea 0.1.1.tar.gz 1. SHOULD follow https://fedoraproject.org/wiki/Packaging:SourceURL#Git_Tags so tarball name could be more legible (ie, be of the form: %{name}-%{version}.tar.gz) 2. license NOT ok, README.md explicitly mentions MIT, so this MUST be: License: MIT $ rpmlint *.src.rpm mkdocs-material.src: W: no-version-in-last-changelog 3. SHOULD follow changelog guidelines: https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Changelogs all of which explicitly include the version-release of the package macros: ok scriptlets: ok (n/a) please fix MUST item 2, and consider addressing SHOULD items 1,3 as well Spec URL: https://williamjmorenor.fedorapeople.org/rpmdev/mkdocs-material.spec SRPM URL: https://williamjmorenor.fedorapeople.org/rpmdev/mkdocs-material-0.2.2-1.fc25.src.rpm Update to last release Fix license tag Fix changelog Ping! Thanks for reminder, looks good. APPROVED Thanks for the review. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/mkdocs-material mkdocs-material-0.2.2-1.fc24 mkdocs-cinder-0.9.3-1.fc24 mkdocs-basic-theme-1.0.1-3.fc24 mkdocs-alabaster-0.7.1-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-988ac47c35 mkdocs-alabaster-0.7.1-1.fc24, mkdocs-basic-theme-1.0.1-3.fc24, mkdocs-cinder-0.9.3-1.fc24, mkdocs-material-0.2.2-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-988ac47c35 mkdocs-alabaster-0.7.1-1.fc24, mkdocs-basic-theme-1.0.1-3.fc24, mkdocs-cinder-0.9.3-1.fc24, mkdocs-material-0.2.2-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. |