Bug 1307149 - Review Request: mkdocs-material - A material design theme for MkDocs
Summary: Review Request: mkdocs-material - A material design theme for MkDocs
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-02-12 20:33 UTC by William Moreno
Modified: 2016-05-20 17:42 UTC (History)
2 users (show)

(edit)
Clone Of:
(edit)
Last Closed: 2016-05-20 17:42:25 UTC
rdieter: fedora-review+


Attachments (Terms of Use)

Description William Moreno 2016-02-12 20:33:43 UTC
Spec URL: https://williamjmorenor.fedorapeople.org/rpmdev/mkdocs-material.spec
SRPM URL: https://williamjmorenor.fedorapeople.org/rpmdev/mkdocs-material-0.1.1-1.fc24.src.rpm
Description: A material design theme for MkDocs
Fedora Account System Username: williamjmorenor

Comment 1 Rex Dieter 2016-04-05 17:03:36 UTC
I can review this

Comment 2 Rex Dieter 2016-04-05 17:10:52 UTC
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=13566708

naming: ok

sources: ok (mostly)
4d0a704ab73d2c4dafc313ec313362ea  0.1.1.tar.gz

1. SHOULD follow
https://fedoraproject.org/wiki/Packaging:SourceURL#Git_Tags
so tarball name could be more legible (ie, be of the form:  %{name}-%{version}.tar.gz)

2. license NOT ok, README.md explicitly mentions MIT, so this MUST be:
License: MIT

$ rpmlint *.src.rpm
mkdocs-material.src: W: no-version-in-last-changelog

3. SHOULD follow changelog guidelines:
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Changelogs
all of which explicitly include the version-release of the package

macros: ok

scriptlets: ok (n/a)


please fix MUST item 2, and consider addressing SHOULD items 1,3 as well

Comment 3 William Moreno 2016-04-08 21:47:56 UTC
Spec URL: https://williamjmorenor.fedorapeople.org/rpmdev/mkdocs-material.spec
SRPM URL: https://williamjmorenor.fedorapeople.org/rpmdev/mkdocs-material-0.2.2-1.fc25.src.rpm

Update to last release
Fix license tag
Fix changelog

Comment 4 William Moreno 2016-04-26 14:31:04 UTC
Ping!

Comment 5 Rex Dieter 2016-04-26 18:53:28 UTC
Thanks for reminder, looks good.

APPROVED

Comment 6 William Moreno 2016-04-26 21:00:43 UTC
Thanks for the review.

Comment 7 Gwyn Ciesla 2016-04-27 14:11:00 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/mkdocs-material

Comment 8 Fedora Update System 2016-05-04 04:21:15 UTC
mkdocs-material-0.2.2-1.fc24 mkdocs-cinder-0.9.3-1.fc24 mkdocs-basic-theme-1.0.1-3.fc24 mkdocs-alabaster-0.7.1-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-988ac47c35

Comment 9 Fedora Update System 2016-05-04 14:29:08 UTC
mkdocs-alabaster-0.7.1-1.fc24, mkdocs-basic-theme-1.0.1-3.fc24, mkdocs-cinder-0.9.3-1.fc24, mkdocs-material-0.2.2-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-988ac47c35

Comment 10 Fedora Update System 2016-05-20 17:42:18 UTC
mkdocs-alabaster-0.7.1-1.fc24, mkdocs-basic-theme-1.0.1-3.fc24, mkdocs-cinder-0.9.3-1.fc24, mkdocs-material-0.2.2-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.