Bug 1308099

Created attachment 1126358 [details]
build.log

Created attachment 1126359 [details]
root.log

Created attachment 1126360 [details]
state.log

This bug appears to have been reported against 'rawhide' during the Fedora 24 development cycle.
Changing version to '24'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora24#Rawhide_Rebase

I will fix this!

Created attachment 1161320 [details]
Fix test suite for RSpec 3 compatibility

I fixed the test suite for RSpec 3.

# Highlight

- I did not update the rubygem-xpath version because it was latest version.
- Removed below line for rpmlint.
  Provides: rubygem(%{gem_name}) = %{version}

# Others
- Dependency: ok
- Install & Irb check: ok

# Detail for the dependency

$ dnf repoquery --enablerepo=rawhide --whatrequires 'rubygem(xpath)' 2> /dev/null
rubygem-capybara-0:2.4.1-2.fc23.noarch
rubygem-capybara-0:2.4.1-3.fc24.noarch
  => gem spec ok
  => rpm spec ok

$ dnf repoquery --enablerepo=rawhide --whatrequires 'rubygem-xpath' 2> /dev/null
rubygem-xpath-doc-0:2.0.0-1.fc22.noarch

$ dnf repoquery --enablerepo=rawhide-source --arch src --whatrequires 'rubygem(xpath)'
  => no result

$ dnf repoquery --enablerepo=rawhide-source --arch src --whatrequires 'rubygem-xpath'
  => no result

Could you check this?
Thanks.

I'd say that this would be more concise version of your patch:

```
diff --git a/spec/html_spec.rb b/spec/html_spec.rb
index 142cac1..a6e4eeb 100644
--- a/spec/html_spec.rb
+++ b/spec/html_spec.rb
@@ -5,13 +5,13 @@ describe XPath::HTML do
   let(:template) { 'form' }
   let(:template_path) { File.read(File.expand_path("fixtures/#{template}.html", File.dirname(__FILE__))) }
   let(:doc) { Nokogiri::HTML(template_path) }
+  let(:type) {|example| example.metadata[:type]}
 
   def get(*args)
     all(*args).first
   end
 
   def all(*args)
-    type = example.metadata[:type]
     doc.xpath(XPath::HTML.send(subject, *args).to_xpath(type)).map { |node| node[:data] }
   end
 
```

Nevertheless your upstream PR does not pass the test suite, so not sure about it ...

Created attachment 1161997 [details]
Fix test suite for RSpec 3 compatibility

> I'd say that this would be more concise version of your patc

Thanks for your review. I updated my patch, and uploaded it again.
Could you check this?
Thanks.

LGTM. But since I am not maintainer, lets wait for a few days if you get approved, otherwise I'll build it myself in the near future.

Created attachment 1162027 [details]
Fix test suite for RSpec 3 compatibility

I modified the patch a little.
I changed the position of Patch0, under the Source0.
Thanks.

Hi, Vit.

I wait for 1 week from last time.
After that, I have not been able to see the maintainer's response, and have not been able to get approval.
Could you build it yourself?

Thanks.

Ug, am I really the maintainer?  I shouldn't be.  Vit, I've added you to the package administrators so you can push and build as you need.  Should I just orphan it so you can pick it up?

(In reply to Chris Lalancette from comment #12)
> Ug, am I really the maintainer?  I shouldn't be.  Vit, I've added you to the
> package administrators so you can push and build as you need.

Thx for that. I could build it anyway, since I am proven packager ;)

> Should I just orphan it so you can pick it up?

Yes, sure. Thx. I guess you should be able to use use "pkgdb-cli give" command to transfer the rights to me without the orphaning step

jaruga's rubygem-xpath-2.0.0-4.fc25 completed http://koji.fedoraproject.org/koji/buildinfo?buildID=770743

rubygem-xpath-2.0.0-4.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-13342931ae

All right, I think I've made you the maintainer now.  If not, let me know and I'll look again.  Thanks for taking it over!

rubygem-xpath-2.0.0-4.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-13342931ae

(In reply to Chris Lalancette from comment #16)
> All right, I think I've made you the maintainer now.

Yep! Thx.

rubygem-xpath-2.0.0-4.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.