Bug 1308331

Summary: dwh is versionlocked even if not configured
Product: Red Hat Enterprise Virtualization Manager Reporter: Yedidyah Bar David <didi>
Component: rhevm-setup-pluginsAssignee: Yedidyah Bar David <didi>
Status: CLOSED ERRATA QA Contact: Lukas Svaty <lsvaty>
Severity: high Docs Contact:
Priority: medium    
Version: 3.6.0CC: didi, gklein, lsurette, sbonazzo, ykaul, ylavi
Target Milestone: ovirt-4.1.0-alphaKeywords: ZStream
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1380267 (view as bug list) Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Integration RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1380267    

Description Yedidyah Bar David 2016-02-14 10:38:32 UTC
Description of problem:

rhevm-setup-plugins has code to version-lock dwh/reports if found on the system, even if not configured. See also bug 1098191. It might have made sense at the time, because in 3.2/3.3 dwh/reports' setup were not engine-setup plugins but separate utilities.

Need to map all relevant flows and consider dropping this code altogether. If we decide to keep it, probably add condition to lock if configured - either by engine-setup, or if the existing code trying to recognize a configured 3.2/3.3 dwh/reports found them.

Comment 1 Sandro Bonazzola 2016-03-24 09:14:31 UTC
Probably related to bug #1310421

Comment 2 Yaniv Lavi 2016-03-24 09:15:54 UTC
Can you confirm comment 1?

Comment 3 Yedidyah Bar David 2016-03-24 12:44:06 UTC
(In reply to Yaniv Dary from comment #2)
> Can you confirm comment 1?

It's likely correct, but still might require its own patch, so can't close duplicate, because in existing setups we might want to remove the versionlock.

Comment 4 Yaniv Lavi 2016-05-09 11:05:17 UTC
oVirt 4.0 Alpha has been released, moving to oVirt 4.0 Beta target.

Comment 9 Yedidyah Bar David 2016-09-25 13:25:45 UTC
(In reply to Yedidyah Bar David from comment #0)
> Description of problem:
> 
> rhevm-setup-plugins has code to version-lock dwh/reports if found on the
> system, even if not configured.

It also outputs:

[ INFO  ] DWH and/or Reports were found on this system.
          To upgrade them, please run the following commands:
          # yum install rhevm-dwh-setup
          # engine-setup

We should remove this as well. Most likely all of this file.

Comment 10 Yedidyah Bar David 2016-09-28 06:16:11 UTC
I suggest to move this to 4.0, no much point in fixing bug 1360363 if we leave this one.

Comment 12 Lukas Svaty 2017-01-27 14:38:56 UTC
Plugins for dwh and reports were removed. No reason to versionlock reports as they do not exist anymore. Dwh is still versionlocked when installed (as it is prerequisity of dashboard should always be).

Sanity on setup/upgrade where done for verification as this seems like CodeChange. If you believe this needs any further verification feel free to reopen.