Bug 1310421

Summary: Some plugin events run unconditionally
Product: Red Hat Enterprise Virtualization Manager Reporter: Yedidyah Bar David <didi>
Component: rhevm-setup-pluginsAssignee: Simone Tiraboschi <stirabos>
Status: CLOSED DUPLICATE QA Contact: Pavel Stehlik <pstehlik>
Severity: medium Docs Contact:
Priority: high    
Version: 3.6.0CC: dfediuck, gklein, lsurette, sbonazzo, ykaul, ylavi
Target Milestone: ovirt-4.1.0-alpha   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-08-04 10:07:50 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Integration RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Yedidyah Bar David 2016-02-21 12:48:07 UTC 
Description of problem:

Most of the events here, e.g. in [1], should run only if engine is enabled.

[1] setup/plugins/ovirt-engine-setup/rhevm-setup-plugins/distro-rhel/config.py

Version-Release number of selected component (if applicable):

Probably since 3.5 or so

How reproducible:

Always I think, didn't try

Steps to Reproduce:
1. Install and setup engine+dwh on machine A
2. Install engine+reports on machine B
3. Run engine-setup on machine B, choose to configure only Reports (using existing engine+dwh from machine A)

Actual results:

I think that some plugins will fail while trying to update vdc options.
Even if in scenarios where they do not, they should not run. E.g. if
machine A has engine and on B we ask to configure only dwh+reports, we'll also have A's engine db credentials, thus probably will not fail, but do not want to update vdc options.

Expected results:

A machine setting up things other than the engine should not touch vdc options.

Additional info:
Comment 1 Yaniv Lavi 2016-05-09 10:56:58 UTC 
oVirt 4.0 Alpha has been released, moving to oVirt 4.0 Beta target.
Comment 4 Yaniv Lavi 2016-06-07 01:59:28 UTC 
We will only use GA flag until RHEV GA.
Comment 5 Simone Tiraboschi 2016-08-04 10:07:50 UTC 

*** This bug has been marked as a duplicate of bug 1359832 ***