Bug 1310803

Summary: [RFE] Add support for Nuage to puppet-neutron in 7.3
Product: Red Hat OpenStack Reporter: lokesh.jain
Component: openstack-puppet-modulesAssignee: Jason Guiditta <jguiditt>
Status: CLOSED WONTFIX QA Contact: nlevinki <nlevinki>
Severity: urgent Docs Contact:
Priority: medium    
Version: 7.0 (Kilo)CC: brad, dbecker, jguiditt, lbezdick, lokesh.jain, mburns, morazi, nyechiel, plancast, rhel-osp-director-maint, rhos-flags, scott.drennan, srevivo
Target Milestone: asyncKeywords: FutureFeature, ZStream
Target Release: 7.0 (Kilo)   
Hardware: x86_64   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-09-22 16:29:00 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1258485    
Attachments:
Description Flags
Comparison between 7.3 and 8.0 versions none

Description lokesh.jain 2016-02-22 17:04:56 UTC 
Created attachment 1129411 [details]
Comparison between 7.3 and 8.0 versions

Description of problem:

Code to enable support for Nuage has been merged upstream. The code that was pulled-in is for 8.0 and we would need to pull in 7.3 version.

We need only the following two files from https://review.openstack.org/#/c/214798/

1. lib/puppet/provider/neutron_plugin_nuage/ini_setting.rb (patch set 8)
2. lib/puppet/type/neutron_plugin_nuage.rb (patch set 8)

Attaching the 7.3 and 8.0 version files for reference.
Comment 2 Jason Guiditta 2016-02-26 18:03:13 UTC 
So, after digging around a bit, I now see that the referenced patch was added to puppet-neutron on master before liberty branched, meaning the patch (and a subsequent fix[1]) are on the current upstream master and stable/liberty.  To clarify the request here, you are saying basically everything in the master/liberty patch is unneeded _except_ for the two referenced files, is that correct?  If so, I think the best path here, so this gets at least a bit of proper testing for kilo, is for you (or Ramkumar, who seems to have done the original work) to propose a patch upstream to the stable/kilo branch.  I would think this should include at least the relevant spec (perhaps updated) from the original patch[2].  I may be able to attempt to do the same thing later today, but I am not that familiar with nuage, so it would make more sense for someone who knows it to submit the patch, which I can then backport to OSP7 (and remove the previous two, as shown in [1]).  Does that sound reasonable?

[1] https://review.openstack.org/#/q/project:openstack/puppet-neutron+nuage
[2] https://review.openstack.org/#/c/214798/23/spec/unit/provider/neutron_plugin_nuage/ini_setting_spec.rb
Comment 3 Brad P. Crochet 2016-03-09 15:26:32 UTC 
Has there been any progress on the backport, Lokesh?
Comment 4 lokesh.jain 2016-03-09 18:24:23 UTC 
We are working on verifying the changes with the latest OSP-D 7.3 build. After Nuage integration verification is done, will start working on up-streaming these changes.
Comment 5 lokesh.jain 2016-04-05 16:31:56 UTC 
Added Openstack gerrit review ID 298792, that has the backported changes to stable/kilo. Please update OSP7.3 to include the changes.
Comment 6 lokesh.jain 2016-04-05 16:32:08 UTC 
*** Bug 1323846 has been marked as a duplicate of this bug. ***
Comment 8 Jason Guiditta 2016-05-03 13:18:56 UTC 
Need acks to get this into osp 7.x
Comment 14 Scott Drennan 2016-09-22 16:29:00 UTC 
At this point, we have a workaround to manually update the required packages, and given OSPD 7.x is not planned for further releases, let's just close this out.