Bug 1310901
Summary: | Review Request: libmodsecurity - A library that loads/interprets rules written in the ModSecurity SecRules | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Othman Madjoudj <athmanem> |
Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <zebob.m> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | mail, package-review, zebob.m |
Target Milestone: | --- | Flags: | zebob.m:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2020-05-19 09:57:33 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1311288, 1485912 |
Description
Othman Madjoudj
2016-02-22 23:10:58 UTC
Notes: - There's couple of issues with a workaround in the spec that were reported upstream - Libinjection is supposed to be bundled (same as with mod_security 2.x): https://github.com/client9/libinjection#embedding New release Spec URL: https://athmane.fedorapeople.org/review/libmodsecurity.spec Spec SRPM: https://athmane.fedorapeople.org/review/libmodsecurity-3.0.0-0.rc1.src.rpm Hello, - Your Release: is missing the dist tag: Release: 0.%{extra_rel}%{?dist} - It is not necessary to add make to the BR. - The versioning is wrong, the release tag should start at 0.1 (Cf https://fedoraproject.org/wiki/Package_Versioning_Examples ): Release: 0.1.%{extra_rel}%{?dist} And: * Wed Aug 30 2017 Athmane Madjoudj <athmane> - 3.0.0-0.1.rc1 - Koji is not very happy, your package fails on all arches besides i386 and x86_64: https://koji.fedoraproject.org/koji/taskinfo?taskID=21607088 This package won't be accepted until this is solved. Report bugs upstream/fix the bugs/add ExclusiveArch with valid reasons as to why you need specific arches only. Thank you for your input. Release tag fixed, I'll check the build on non-x86 archs Regarding make, it does not harm, plus it might be needed with minimal Buildroot [1] [1] https://pagure.io/packaging-committee/issue/490 SPEC: https://athmane.fedorapeople.org/review/libmodsecurity.spec SRPM: https://athmane.fedorapeople.org/review/libmodsecurity-3.0.0-0.1.rc1.fc26.src.rpm Non x86 build fixed, PR opened upstream. SPEC: https://athmane.fedorapeople.org/review/libmodsecurity.spec SRPM: https://athmane.fedorapeople.org/review/libmodsecurity-3.0.0-0.2.rc1.fc27.src.rpm Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=22616953 Perfect, package accepted. (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/libmodsecurity |