| Summary: | UI: Reports - Edit - reset breaks tabs | ||
|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Chris Pelland <cpelland> |
| Component: | UI - OPS | Assignee: | Aparna Karve <akarve> |
| Status: | CLOSED ERRATA | QA Contact: | Ramesh A <rananda> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 5.4.0 | CC: | akarve, cpelland, hkataria, jhardy, jprause, mfeifer, mpovolny, obarenbo, rananda |
| Target Milestone: | GA | Keywords: | ZStream |
| Target Release: | 5.4.5 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | ui:report | ||
| Fixed In Version: | 5.4.5.2 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 1250417 | Environment: | |
| Last Closed: | 2016-03-29 14:18:42 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | 1250417 | ||
| Bug Blocks: | |||
|
Comment 1
Aparna Karve
2016-02-23 21:46:49 UTC
New commit detected on cfme/5.4.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=dd3bc7a55db1917ba394ca983bd869e5f4e3a4da commit dd3bc7a55db1917ba394ca983bd869e5f4e3a4da Author: Aparna Karve <akarve> AuthorDate: Tue Feb 23 13:30:46 2016 -0800 Commit: Aparna Karve <akarve> CommitDate: Wed Feb 24 09:39:13 2016 -0800 Deleted commented code https://bugzilla.redhat.com/show_bug.cgi?id=1311279 .../report_controller/reports/editor.rb | 23 +++++++--------------- 1 file changed, 7 insertions(+), 16 deletions(-) New commit detected on cfme/5.4.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=7299304c05ef0f1708b079121c24e7f59accd100 commit 7299304c05ef0f1708b079121c24e7f59accd100 Author: Harpreet Kataria <hkataria> AuthorDate: Fri Dec 11 12:20:14 2015 -0500 Commit: Aparna Karve <akarve> CommitDate: Wed Feb 24 09:39:06 2016 -0800 Fixed issue in change tab after Reset is pressed in report editor - Fixed code to set prefix correctly for tab ids on tabs in Reports editor after Reset button is pressed - Added spec test to verify tab ids https://bugzilla.redhat.com/show_bug.cgi?id=1311279 vmdb/app/controllers/report_controller.rb | 2 - vmdb/app/controllers/report_controller/reports.rb | 61 ++++++++-------------- .../report_controller/reports/editor.rb | 18 ++----- .../miq_report_controller/reports/editor_spec.rb | 50 ++++++++++++++++++ 4 files changed, 77 insertions(+), 54 deletions(-) New commit detected on cfme/5.4.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=fae2ba545447ddb47510be876ace0612f2399f8c commit fae2ba545447ddb47510be876ace0612f2399f8c Merge: 55bb6dd dd3bc7a Author: Dan Clarizio <dclarizi> AuthorDate: Wed Feb 24 13:13:52 2016 -0500 Commit: Dan Clarizio <dclarizi> CommitDate: Wed Feb 24 13:13:52 2016 -0500 Merge branch 'bz1311279_fix_reset' into '5.4.z' Bz1311279 - Fixed issue in change tab after Reset is pressed in report editor - Fixed code to set prefix correctly for tab ids on tabs in Reports editor after Reset button is pressed - Added spec test to verify tab ids https://bugzilla.redhat.com/show_bug.cgi?id=1311279 See merge request !813 vmdb/app/controllers/report_controller.rb | 2 - vmdb/app/controllers/report_controller/reports.rb | 61 ++++++++-------------- .../report_controller/reports/editor.rb | 41 +++++---------- .../miq_report_controller/reports/editor_spec.rb | 50 ++++++++++++++++++ 4 files changed, 84 insertions(+), 70 deletions(-) Good to go. Verified and working fine in 5.4.5.2.20160315175001_800759c Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2016-0171.html |