Bug 1311279 - UI: Reports - Edit - reset breaks tabs
Summary: UI: Reports - Edit - reset breaks tabs
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.4.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: GA
: 5.4.5
Assignee: Aparna Karve
QA Contact: Ramesh A
URL:
Whiteboard: ui:report
: 1250417 (view as bug list)
Depends On: 1250417
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-02-23 19:44 UTC by Chris Pelland
Modified: 2017-08-30 01:35 UTC (History)
9 users (show)

Fixed In Version: 5.4.5.2
Doc Type: Bug Fix
Doc Text:
Clone Of: 1250417
Environment:
Last Closed: 2016-03-29 14:18:42 UTC
Category: ---
Cloudforms Team: ---
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2016:0171 0 normal SHIPPED_LIVE CFME 5.4.5 bug fixes, and enhancement update 2016-03-29 18:13:52 UTC

Comment 1 Aparna Karve 2016-02-23 21:46:49 UTC
*** Bug 1250417 has been marked as a duplicate of this bug. ***

Comment 2 CFME Bot 2016-02-24 21:54:22 UTC
New commit detected on cfme/5.4.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=dd3bc7a55db1917ba394ca983bd869e5f4e3a4da

commit dd3bc7a55db1917ba394ca983bd869e5f4e3a4da
Author:     Aparna Karve <akarve>
AuthorDate: Tue Feb 23 13:30:46 2016 -0800
Commit:     Aparna Karve <akarve>
CommitDate: Wed Feb 24 09:39:13 2016 -0800

    Deleted commented code
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1311279

 .../report_controller/reports/editor.rb            | 23 +++++++---------------
 1 file changed, 7 insertions(+), 16 deletions(-)

Comment 3 CFME Bot 2016-02-24 21:54:26 UTC
New commit detected on cfme/5.4.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=7299304c05ef0f1708b079121c24e7f59accd100

commit 7299304c05ef0f1708b079121c24e7f59accd100
Author:     Harpreet Kataria <hkataria>
AuthorDate: Fri Dec 11 12:20:14 2015 -0500
Commit:     Aparna Karve <akarve>
CommitDate: Wed Feb 24 09:39:06 2016 -0800

    Fixed issue in change tab after Reset is pressed in report editor
    - Fixed code to set prefix correctly for tab ids on tabs in Reports editor after Reset button is pressed
    - Added spec test to verify tab ids
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1311279

 vmdb/app/controllers/report_controller.rb          |  2 -
 vmdb/app/controllers/report_controller/reports.rb  | 61 ++++++++--------------
 .../report_controller/reports/editor.rb            | 18 ++-----
 .../miq_report_controller/reports/editor_spec.rb   | 50 ++++++++++++++++++
 4 files changed, 77 insertions(+), 54 deletions(-)

Comment 4 CFME Bot 2016-02-24 21:54:29 UTC
New commit detected on cfme/5.4.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=fae2ba545447ddb47510be876ace0612f2399f8c

commit fae2ba545447ddb47510be876ace0612f2399f8c
Merge: 55bb6dd dd3bc7a
Author:     Dan Clarizio <dclarizi>
AuthorDate: Wed Feb 24 13:13:52 2016 -0500
Commit:     Dan Clarizio <dclarizi>
CommitDate: Wed Feb 24 13:13:52 2016 -0500

    Merge branch 'bz1311279_fix_reset' into '5.4.z'
    
    Bz1311279 - Fixed issue in change tab after Reset is pressed in report editor
    
    - Fixed code to set prefix correctly for tab ids on tabs in Reports editor after Reset button is pressed
    - Added spec test to verify tab ids
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1311279
    
    See merge request !813

 vmdb/app/controllers/report_controller.rb          |  2 -
 vmdb/app/controllers/report_controller/reports.rb  | 61 ++++++++--------------
 .../report_controller/reports/editor.rb            | 41 +++++----------
 .../miq_report_controller/reports/editor_spec.rb   | 50 ++++++++++++++++++
 4 files changed, 84 insertions(+), 70 deletions(-)

Comment 6 Ramesh A 2016-03-22 12:07:14 UTC
Good to go.  Verified and working fine in 5.4.5.2.20160315175001_800759c

Comment 8 errata-xmlrpc 2016-03-29 14:18:42 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-0171.html


Note You need to log in before you can comment on or make changes to this bug.