Bug 1311358

Summary: FTBFS - gnuradio fails to build with cmake 3.5
Product: [Fedora] Fedora Reporter: Orion Poplawski <orion>
Component: gnuradioAssignee: Jaroslav Škarvada <jskarvad>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: jskarvad, lucilanga, mmahut, orion
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-02-24 11:35:37 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Orion Poplawski 2016-02-24 02:52:00 UTC
Description of problem:

gnuradio fails to build with cmake 3.5.  I believe this it because of things like:

./gnuradio-3.7.9.1/volk/CMakeLists.txt:
set(CMAKE_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR}) #allows this to be a sub-project
set(CMAKE_BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR}) #allows this to be a sub-project

Setting CMAKE_SOURCE_DIR or CMAKE_BINARY_DIR has never been supported, but appears to definitely no longer allowed to be changed with 3.5.

Comment 1 Orion Poplawski 2016-02-24 03:55:10 UTC
I've checked in a fix.  The proper thing to do is to use PROJECT_SOURCE_DIR/PROJECT_BINARY_DIR.  This would work back to at least cmake 2.8.  I'll let you pass this on to upstream.

Comment 2 Jaroslav Škarvada 2016-02-24 11:35:37 UTC
Thanks, upstream ticket:
http://gnuradio.org/redmine/issues/905

Comment 3 Jaroslav Škarvada 2016-02-24 17:07:01 UTC
Orion please could you comment in the github pull request?
https://github.com/gnuradio/volk/pull/65