Bug 1311358 - FTBFS - gnuradio fails to build with cmake 3.5
FTBFS - gnuradio fails to build with cmake 3.5
Product: Fedora
Classification: Fedora
Component: gnuradio (Show other bugs)
All Linux
unspecified Severity medium
: ---
: ---
Assigned To: Jaroslav Škarvada
Fedora Extras Quality Assurance
Depends On:
  Show dependency treegraph
Reported: 2016-02-23 21:52 EST by Orion Poplawski
Modified: 2016-02-24 12:21 EST (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2016-02-24 06:35:37 EST
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description Orion Poplawski 2016-02-23 21:52:00 EST
Description of problem:

gnuradio fails to build with cmake 3.5.  I believe this it because of things like:

set(CMAKE_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR}) #allows this to be a sub-project
set(CMAKE_BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR}) #allows this to be a sub-project

Setting CMAKE_SOURCE_DIR or CMAKE_BINARY_DIR has never been supported, but appears to definitely no longer allowed to be changed with 3.5.
Comment 1 Orion Poplawski 2016-02-23 22:55:10 EST
I've checked in a fix.  The proper thing to do is to use PROJECT_SOURCE_DIR/PROJECT_BINARY_DIR.  This would work back to at least cmake 2.8.  I'll let you pass this on to upstream.
Comment 2 Jaroslav Škarvada 2016-02-24 06:35:37 EST
Thanks, upstream ticket:
Comment 3 Jaroslav Škarvada 2016-02-24 12:07:01 EST
Orion please could you comment in the github pull request?

Note You need to log in before you can comment on or make changes to this bug.