Bug 1311536
| Summary: | python-django-helpdesk: Provide a Python 3 subpackage | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tomas Orsava <torsava> |
| Component: | python-django-helpdesk | Assignee: | Luis Bazan <bazanluis20> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 25 | CC: | bazanluis20, cstratak, dkrejci, jberan, pviktori |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | python-django-helpdesk-0.1.18-1.fc26 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-11-18 15:13:45 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1285816, 1333770 | ||
| Attachments: | |||
|
Description
Tomas Orsava
2016-02-24 12:25:37 UTC
Luis, do you need any help with adding Python 3 support? This bug appears to have been reported against 'rawhide' during the Fedora 25 development cycle. Changing version to '25'. Created attachment 1193023 [details]
Update to patched 0.1.17 version including Python 3 subpackage
I prepared a spec file update that includes
- update to patched version 0.1.17
- source update
- modernized specfile with Python 3 packaging
The attached specfile contains also a correction related to this bug that occurs in the original spec file: $ rpmlint python-django-helpdesk.spec python-django-helpdesk.spec: E: specfile-error warning: bogus date in %changelog: Tue Oct 22 2014 Luis Bazan <lbazan> - 0.1.12-4 0 packages and 1 specfiles checked; 1 errors, 0 warnings. Hi Jan! That's an awesome patch, good work! Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15348756 However, since the changes are not only to the spec file, but you've also added a patch and new sources, it would be highly recommended that you provide a patch that encompasses the changes to the whole git repo, not just the now contents of the spec file. If you'd be interested, I can show you how to do that. Created attachment 1193408 [details]
Patch: syntax correction for Python 3.4 and 3.5
Hi Tomáš,
thanks for your review. I attach the patch. If anything else should be done, please let me know.
Created attachment 1199061 [details]
Update to patched 0.1.17 version including Python 3 subpackage
Adjusted spec file
Created attachment 1199122 [details]
Update to patched 0.1.17 version including Python 3 subpackage
Added fix of sum/summary.
Hi Jan, I have some comments. * Please do not add " - Python 2/3 version" to summaries, it is too long, just keep it in descriptions. * Add %doc README.rst to %files. Created attachment 1199444 [details]
Update to patched 0.1.17 version including Python 3 subpackage
Hi Dominika, thank you for the review. I attach the new version updated as required.
Hi Jan, the patch looks good to me now. If maintainer has nothing against, we can push this change after a week. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15761313 Created attachment 1218839 [details]
Update to new 0.1.18 version including Python 3 subpackage
Fixed in rawhide. If you need this also for F25 please reopen the bug. |