Bug 1311959 (icecream)

Summary:	Review Request: icemon - Icecream Graphical Monitor
Product:	[Fedora] Fedora	Reporter:	Helio Chissini de Castro <helio>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED DUPLICATE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, projects.rg, zbyszek
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:	AwaitingSubmitter
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-10-07 11:44:25 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Helio Chissini de Castro 2016-02-25 12:10:08 UTC

Spec URL: https://heliocastro.fedorapeople.org/icemon.spec
SRPM URL: https://heliocastro.fedorapeople.org/icemon-3.0.1-1.fc23.src.rpm
Description: Icecream Graphical Monitor
Fedora Account System Username: heliocastro

Comment 1 Helio Chissini de Castro 2016-02-26 08:53:53 UTC

Updated spec and srpm

Comment 2 Raphael Groner 2016-03-06 17:02:46 UTC

Some general hints before I can run f-r tool:

a. Please use %license COPYING, remove obsolete %doc COPYING .
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text

b. As you place additional icons, Requires: hicolor-icon-theme
https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_also_owned_by_a_package_implementing_required_functionality_of_your_package

c. Icons need scriptlets for gtk cache to be executed.
https://fedoraproject.org/wiki/Packaging:Scriptlets#Icon_Cache

Are you interested in a review swap?

Comment 3 Raphael Groner 2016-03-06 17:07:06 UTC

d. Why not provide documentation (from doc subfolder) in the package?
dd. Please also add %doc *.md

Comment 4 Zbigniew Jędrzejewski-Szmek 2017-07-27 23:15:17 UTC


*** This bug has been marked as a duplicate of bug 1476014 ***