Bug 1311959 (icecream) - Review Request: icemon - Icecream Graphical Monitor
Summary: Review Request: icemon - Icecream Graphical Monitor
Keywords:
Status: CLOSED DUPLICATE of bug 1476014
Alias: icecream
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: AwaitingSubmitter
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-02-25 12:10 UTC by Helio Chissini de Castro
Modified: 2017-07-27 23:15 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-10-07 11:44:25 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1476014 0 medium CLOSED Review Request: icemon - Icecream GUI monitor 2021-02-22 00:41:40 UTC

Internal Links: 1476014

Description Helio Chissini de Castro 2016-02-25 12:10:08 UTC
Spec URL: https://heliocastro.fedorapeople.org/icemon.spec
SRPM URL: https://heliocastro.fedorapeople.org/icemon-3.0.1-1.fc23.src.rpm
Description: Icecream Graphical Monitor
Fedora Account System Username: heliocastro

Comment 1 Helio Chissini de Castro 2016-02-26 08:53:53 UTC
Updated spec and srpm

Comment 2 Raphael Groner 2016-03-06 17:02:46 UTC
Some general hints before I can run f-r tool:

a. Please use %license COPYING, remove obsolete %doc COPYING .
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text

b. As you place additional icons, Requires: hicolor-icon-theme
https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_also_owned_by_a_package_implementing_required_functionality_of_your_package

c. Icons need scriptlets for gtk cache to be executed.
https://fedoraproject.org/wiki/Packaging:Scriptlets#Icon_Cache

Are you interested in a review swap?

Comment 3 Raphael Groner 2016-03-06 17:07:06 UTC
d. Why not provide documentation (from doc subfolder) in the package?
dd. Please also add %doc *.md

Comment 4 Zbigniew Jędrzejewski-Szmek 2017-07-27 23:15:17 UTC

*** This bug has been marked as a duplicate of bug 1476014 ***


Note You need to log in before you can comment on or make changes to this bug.