Bug 1312040

Summary:	Pacemaker used with CMAN should not ship ocf:pacemaker:controld RA
Product:	Red Hat Enterprise Linux 6	Reporter:	Jan Pokorný [poki] <jpokorny>
Component:	pacemaker	Assignee:	Ken Gaillot <kgaillot>
Status:	CLOSED ERRATA	QA Contact:	cluster-qe <cluster-qe>
Severity:	low	Docs Contact:
Priority:	low
Version:	6.8	CC:	abeekhof, cluster-maint, jruemker, mnovacek
Target Milestone:	rc
Target Release:	6.9
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	pacemaker-1.1.15-1.el6	Doc Type:	No Doc Update
Doc Text:	undefined	Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-03-21 09:51:21 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jan Pokorný [poki] 2016-02-25 15:27:48 UTC

As it is too late to try change anything such late in the game
as the initscripts had already started dlm_controld by the time
Pacemaker is started.

Users should not be misled to think that agent is of any use
in Pacemaker + CMAN scenario.

At least this was one of the observations that arose from one of
the internal discussions (take it with a grain of salt for now).

Comment 1 Jan Pokorný [poki] 2016-05-24 21:46:26 UTC

I was trying to reconsider whether this is a good idea or not.

Why it is a good idea to drop this from Pacemaker-CMAN orchestra:

1. /etc/init.d/cman start/stops both {dlm,gfs}_controld automatically,
   so it should(?) work just as predestined in ocf:pacemaker:controld
   agent (globally unique clones)

2. agent uses "-s 0" as a default option, and this is not recognized
   by RHEL 6 dlm version:
# dlm_controld -V
> dlm_controld 3.0.12.1 (built Feb  1 2016 07:06:27)
> Copyright (C) Red Hat, Inc.  2004-2010  All rights reserved.
# dlm_controld -s 0
> dlm_controld: invalid option -- 's'
> Please use '-h' for usage.

3. even if start and monitor actions might work well out of the box,
   it's unclear if Pacemaker-triggered stop action would be acceptable
   under all circumstances (note that dlm_controld is started before
   gfs_controld and they are stopped in reverse order in cman initscript)


Plus consider a subtle character of DLM/Pacemaker integration (not sure
if that affects CMAN/fenced as well):
[bug 1268313]
https://github.com/ClusterLabs/pacemaker/pull/839

Comment 2 Ken Gaillot 2016-05-24 22:02:51 UTC

It does make sense to remove it. In RHEL 6, the CMAN init script manages dlm_controld, so it should not be managed as a cluster resource.

Comment 3 Jan Pokorný [poki] 2016-05-30 18:57:51 UTC

Upstream commit
https://github.com/ClusterLabs/pacemaker/pull/1011/commits/6a11d2069dcaa57b445f73b52f642f694e55caf3
(syntax issue fixed in 
https://github.com/ClusterLabs/pacemaker/pull/1028/commits/aa5509df412cb9ea39ae3d3918e0c66c326cda77
)
was merged and is present in Pacemaker-1.15-rc3+.

Comment 7 michal novacek 2017-01-13 15:17:40 UTC

I have verified that ocf:pacemaker:controld is not part of pacemaker rpm in pacemaker-1.1.15-4

before the fix pacemaker-1.1.15-3.el6.x86_64
============================================

# rpm -ql paceamker | grep controld
/usr/lib/ocf/resource.d/pacemaker/controld
/usr/share/man/man7/ocf_pacemaker_controld.7.gz
#

after the fix pacemaker-1.1.15-3.el6.x86_64
===========================================
# rpm -ql paceamker | grep controld
#

Comment 9 errata-xmlrpc 2017-03-21 09:51:21 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHEA-2017-0629.html