Bug 1312303

Please update perl-Net-LDAP-Server-Test to the latest version 0.21 and add build-requires 'make' and 'perl-generators'.

(In reply to Jitka Plesnikova from comment #1)
> Please update perl-Net-LDAP-Server-Test to the latest version 0.21
Sigh, ... I'd rather have avoided this :)

Net-LDAP-Server-Test pulls in yet a another dep (perl-Net-LDAP-SID).

Update to 0.21:

Spec URL: https://corsepiu.fedorapeople.org/packages/perl-Net-LDAP-Server-Test.spec
SRPM URL: https://corsepiu.fedorapeople.org/packages/perl-Net-LDAP-Server-Test-0.21-1.fc26.src.rpm

ATM, this package only builds on rawhide, because the new dependency (perl-Net-LDAP-SID) is not yet in fedora < rawhide.

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --requires perl-Net-LDAP-Server-Test-0.21-1.fc26.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.24.0)
      1 perl(Carp)
      1 perl(Convert::ASN1)
      1 perl(Data::Dump)
      1 perl(IO::Select)
      1 perl(IO::Socket)
      1 perl(Net::LDAP::ASN)
      1 perl(Net::LDAP::Constant)
      1 perl(Net::LDAP::Control)
      1 perl(Net::LDAP::Entry)
      1 perl(Net::LDAP::Filter)
      1 perl(Net::LDAP::FilterMatch)
      1 perl(Net::LDAP::SID)
      1 perl(Net::LDAP::Server)
      1 perl(Net::LDAP::Util)
      1 perl(base)
      1 perl(constant)
      1 perl(fields)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Net-LDAP-Server-Test-0.21-1.fc26.noarch.rpm | sort | uniq -c
      1 perl(Net::LDAP::Server::Test) = 0.21
      1 perl-Net-LDAP-Server-Test = 0.21-1.fc26
Binary provides are Ok.

$ rpmlint ./perl-Net-LDAP-Server-Test*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

FIX: Please add following build-requires:
   perl(File::Temp) - t/06-no-such-entry.t:10, t/07-error-codes.t:10
   perl(Net::LDAP::LDIF) - t/06-no-such-entry.t:9, t/06-no-such-entry.t:9
   perl(IO::Socket::INET) - t/03-socket.t:10

FIX: The latest version is 0.22. There is no code change. 

TODO: Please replace PERL_INSTALL_ROOT with more common DESTDIR.

Please correct all 'FIX' issues and consider fixing 'TODO' items and
provide new spec file.

Not approved.

Spec URL: https://corsepiu.fedorapeople.org/packages/perl-Net-LDAP-Server-Test.spec
SRPM URL: https://corsepiu.fedorapeople.org/packages/perl-Net-LDAP-Server-Test-0.21-2.fc26.src.rpm

> FIX: Please add following build-requires:
>    perl(File::Temp) - t/06-no-such-entry.t:10, t/07-error-codes.t:10
>    perl(Net::LDAP::LDIF) - t/06-no-such-entry.t:9, t/06-no-such-entry.t:9
>    perl(IO::Socket::INET) - t/03-socket.t:10
+BuildRequires:  perl(File::Temp)
+BuildRequires:  perl(IO::Socket::INET)
+BuildRequires:  perl(Net::LDAP::LDIF)
Ok

> FIX: The latest version is 0.22. There is no code change. 
Please update it before submit.

> TODO: Please replace PERL_INSTALL_ROOT with more common DESTDIR.
-%{__make} pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
+%{__make} pure_install DESTDIR=$RPM_BUILD_ROOT
Ok

 
Otherwise the package looks good.
Approved.

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Net-LDAP-Server-Test