Bug 1403235 - Review Request: perl-Net-LDAP-SID - Net::LDAP::SID Perl module
Summary: Review Request: perl-Net-LDAP-SID - Net::LDAP::SID Perl module
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1312303
TreeView+ depends on / blocked
 
Reported: 2016-12-09 13:23 UTC by Ralf Corsepius
Modified: 2016-12-21 04:29 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-12-21 04:29:27 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Ralf Corsepius 2016-12-09 13:23:59 UTC
Spec URL: https://corsepiu.fedorapeople.org/packages/perl-Net-LDAP-SID.spec
SRPM URL: https://corsepiu.fedorapeople.org/packages/perl-Net-LDAP-SID-0.001-1.fc26.src.rpm
Description: Active Directory Security Identifier manipulation
Fedora Account System Username: corsepiu

Comment 1 Jitka Plesnikova 2016-12-09 14:10:37 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Net-LDAP-SID-0.001-1.fc26.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.24.0)
      1 perl(Carp)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Net-LDAP-SID-0.001-1.fc26.noarch.rpm | sort | uniq -c
      1 perl(Net::LDAP::SID) = 0.001
      1 perl-Net-LDAP-SID = 0.001-1.fc26
Binary provides are Ok.

$ rpmlint ./perl-Net-LDAP-SID*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

Rpmlint is ok

The package looks good.
Approved

Comment 2 Gwyn Ciesla 2016-12-09 14:29:12 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Net-LDAP-SID

Comment 3 Ralf Corsepius 2016-12-09 14:31:34 UTC
Thanks for the quick review. Provided my experiences with Fedora packaging in recent months, I feared this additional dep would delay perl-Net-LDAP-Server for yet another couple of months :(

Comment 4 Jitka Plesnikova 2016-12-09 14:53:47 UTC
I can do the review of perl-Net-LDAP-Server next week, in case the perl-Net-LDAP-SID will be in rawhide.


Note You need to log in before you can comment on or make changes to this bug.