Bug 1312360

Summary:	Review Request: python-rcssmin - CSS Minifier
Product:	[Fedora] Fedora	Reporter:	Matthias Runge <mrunge>
Component:	Package Review	Assignee:	Zbigniew Jędrzejewski-Szmek <zbyszek>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, zbyszek
Target Milestone:	---	Flags:	zbyszek: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-05-02 17:33:26 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Bug Depends On:
Bug Blocks:	1296716

Description Matthias Runge 2016-02-26 14:25:45 UTC

Spec URL: http://matthias-runge.de/fedora/python-rcssmin.spec
SRPM URL: http://matthias-runge.de/fedora/python-rcssmin-1.0.6-1.fc23.src.rpm
Description: RCSSmin is a CSS minifier.                                                     
                                                                               
The minifier is based on the semantics of the YUI compressor, which itself     
is based on the rule list by Isaac Schlueter.                                  
                                                                               
This module is a re-implementation aiming for speed instead of maximum         
compression, so it can be used at runtime (rather than during a preprocessing  
step).            
Fedora Account System Username: mrunge

Comment 1 Zbigniew Jędrzejewski-Szmek 2016-02-28 03:33:23 UTC

Why remove the documentation?

+ latest version
+ license is OK (ASL 2.0)
+ license file is present
- %license is not used (Please use %license for LICENSE in %files).
+ new python template is used
+ provides, requires look OK
+ rpmlint has nothing useful to say


rpmlint:
Checking: python2-rcssmin-1.0.6-1.fc25.i686.rpm
          python3-rcssmin-1.0.6-1.fc25.i686.rpm
          python-rcssmin-debuginfo-1.0.6-1.fc25.i686.rpm
          python-rcssmin-1.0.6-1.fc25.src.rpm
python2-rcssmin.i686: W: spelling-error %description -l en_US minifier -> magnifier
python2-rcssmin.i686: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment
python2-rcssmin.i686: W: spelling-error %description -l en_US preprocessing -> reprocessing, p reprocessing, teleprocessing
python2-rcssmin.i686: E: non-standard-executable-perm /usr/lib/python2.7/site-packages/_rcssmin.so 775
python3-rcssmin.i686: W: spelling-error %description -l en_US minifier -> magnifier
python3-rcssmin.i686: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment
python3-rcssmin.i686: W: spelling-error %description -l en_US preprocessing -> reprocessing, p reprocessing, teleprocessing
python3-rcssmin.i686: E: non-standard-executable-perm /usr/lib/python3.5/site-packages/_rcssmin.cpython-35m-i386-linux-gnu.so 775
python-rcssmin.src: W: spelling-error %description -l en_US minifier -> magnifier
python-rcssmin.src: W: spelling-error %description -l en_US runtime -> run time, run-time, rudiment
python-rcssmin.src: W: spelling-error %description -l en_US preprocessing -> reprocessing, p reprocessing, teleprocessing
4 packages and 0 specfiles checked; 2 errors, 9 warnings.
All OK.

Package is APPROVED. Please use %license before uploading.

Comment 2 Matthias Runge 2016-02-29 06:32:39 UTC

Thank you for this quick review!

I will fix the mentioned issues before submitting.

Comment 3 Gwyn Ciesla 2016-02-29 13:33:30 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/python-rcssmin

Comment 4 Mike McCune 2016-03-28 23:47:57 UTC

This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions