| Summary: | Review Request: python-sphinxcontrib-bibtex - Sphinx extension for BibTeX style citations | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jerry James <loganjerry> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, zbyszek |
| Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-03-05 16:00:42 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | 1304217, 1312406, 1312408, 1312409 | ||
| Bug Blocks: | |||
|
Description
Jerry James
2016-02-26 16:05:28 UTC
I'll review this when deps are done. Thank you so much for picking up all of these reviews. I really appreciate it. Since you haven't started on this one yet, I have sneakily made the same changes you requested in the other python packages. New URLs: Spec URL: https://jjames.fedorapeople.org/python-sphinxcontrib-bibtex/python-sphinxcontrib-bibtex.spec SRPM URL: https://jjames.fedorapeople.org/python-sphinxcontrib-bibtex/python-sphinxcontrib-bibtex-0.3.3-1.fc25.src.rpm nosetests -v, so the test names are printed.
/usr/share/doc/python{2,3}-sphinxcontrib-bibtex/ are 1MB each, it would be nice to have a shared -doc subpackage.
+ latest version
+ license is acceptable (BSD)
+ license file is present, %license is used
+ provides/requires look OK
+ %python_provide is used
+ %check is present and passes
+ no scriptlets required or present
+ rpmlint is OK:
python2-sphinxcontrib-bibtex.noarch: W: spelling-error %description -l en_US thebibliography -> the bibliography, the-bibliography, bibliography
python2-sphinxcontrib-bibtex.noarch: W: spelling-error %description -l en_US pybtex -> Playtex
python3-sphinxcontrib-bibtex.noarch: W: spelling-error %description -l en_US thebibliography -> the bibliography, the-bibliography, bibliography
python3-sphinxcontrib-bibtex.noarch: W: spelling-error %description -l en_US pybtex -> Playtex
python-sphinxcontrib-bibtex.src: W: spelling-error %description -l en_US thebibliography -> the bibliography, the-bibliography, bibliography
python-sphinxcontrib-bibtex.src: W: spelling-error %description -l en_US pybtex -> Playtex
python-sphinxcontrib-bibtex.src:67: W: unversioned-explicit-provides bundled(jquery)
python-sphinxcontrib-bibtex.src:68: W: unversioned-explicit-provides bundled(js-underscore)
python-sphinxcontrib-bibtex.src:83: W: unversioned-explicit-provides bundled(jquery)
python-sphinxcontrib-bibtex.src:84: W: unversioned-explicit-provides bundled(js-underscore)
3 packages and 0 specfiles checked; 0 errors, 10 warnings.
+ package works fine, nice documentation
Package is APPROVED. Please consider splitting out -doc subpackage.
Okay, I will add -v to the nosetests invocations and split out -doc. Thank you very much for reviewing this pile of packages! I appreciate your effort. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/python-sphinxcontrib-bibtex |