Bug 1312406 - Review Request: python-orderedset - Ordered set implementation in Cython
Summary: Review Request: python-orderedset - Ordered set implementation in Cython
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1312410
TreeView+ depends on / blocked
 
Reported: 2016-02-26 16:05 UTC by Jerry James
Modified: 2016-03-05 15:59 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-03-05 15:59:12 UTC
Type: ---
zbyszek: fedora-review+


Attachments (Terms of Use)

Description Jerry James 2016-02-26 16:05:05 UTC
Spec URL: https://jjames.fedorapeople.org/python-orderedset/python-orderedset.spec
SRPM URL: https://jjames.fedorapeople.org/python-orderedset/python-orderedset-2.0-1.fc24.src.rpm
Fedora Account System Username: jjames
Description: Orderedset contains an ordered set implementation in Cython. Features:
- Works like a regular set, but remembers insertion order;
- Is approximately 5 times faster than the pure Python implementation overall (and 5 times slower than set);
- Compatible with Python 2.6 through 3.4.;
- Supports the full set interface;
- Supports some list methods, like index and __getitem__;
- Supports set methods against iterables.

Comment 1 Zbigniew Jędrzejewski-Szmek 2016-02-28 02:31:15 UTC
Would it be possible to build both versions from the same build directory?

Comment 2 Zbigniew Jędrzejewski-Szmek 2016-02-28 02:34:00 UTC
Hm, you're building it for rawhide. Is it incompatible with Python 3.5? Most likely you can drop this line from the description, it's not relevant to distribution users.

Comment 3 Jerry James 2016-03-03 03:25:16 UTC
(In reply to Zbigniew Jędrzejewski-Szmek from comment #1)
> Would it be possible to build both versions from the same build directory?

As I mentioned in the other bug, I would really rather not, even if it is possible.  This way I know that neither build has affected the other.

(In reply to Zbigniew Jędrzejewski-Szmek from comment #2)
> Hm, you're building it for rawhide. Is it incompatible with Python 3.5? Most
> likely you can drop this line from the description, it's not relevant to
> distribution users.

Right, I will remove that line from the description.  Do you want a new source RPM with just the one change?

Comment 4 Zbigniew Jędrzejewski-Szmek 2016-03-03 13:11:58 UTC
+ latest version (git snapshot)
+ license is acceptable (BSD)
+ license file is present, %license is used
+ provides/requires look OK
+ %python_provide is used
+ no scriptlets present or necessary
+ rpmlint: spelling-error and unversioned-explicit-provides warnings, both bogus

Package is APPROVED.

Comment 5 Jerry James 2016-03-04 21:10:39 UTC
Thank you again for the review.  New package requested.

Comment 6 Gwyn Ciesla 2016-03-04 22:25:09 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/python-orderedset


Note You need to log in before you can comment on or make changes to this bug.