Red Hat Bugzilla – Bug 1312406
Review Request: python-orderedset - Ordered set implementation in Cython
Last modified: 2016-03-05 10:59:12 EST
Spec URL: https://jjames.fedorapeople.org/python-orderedset/python-orderedset.spec
SRPM URL: https://jjames.fedorapeople.org/python-orderedset/python-orderedset-2.0-1.fc24.src.rpm
Fedora Account System Username: jjames
Description: Orderedset contains an ordered set implementation in Cython. Features:
- Works like a regular set, but remembers insertion order;
- Is approximately 5 times faster than the pure Python implementation overall (and 5 times slower than set);
- Compatible with Python 2.6 through 3.4.;
- Supports the full set interface;
- Supports some list methods, like index and __getitem__;
- Supports set methods against iterables.
Would it be possible to build both versions from the same build directory?
Hm, you're building it for rawhide. Is it incompatible with Python 3.5? Most likely you can drop this line from the description, it's not relevant to distribution users.
(In reply to Zbigniew Jędrzejewski-Szmek from comment #1)
> Would it be possible to build both versions from the same build directory?
As I mentioned in the other bug, I would really rather not, even if it is possible. This way I know that neither build has affected the other.
(In reply to Zbigniew Jędrzejewski-Szmek from comment #2)
> Hm, you're building it for rawhide. Is it incompatible with Python 3.5? Most
> likely you can drop this line from the description, it's not relevant to
> distribution users.
Right, I will remove that line from the description. Do you want a new source RPM with just the one change?
+ latest version (git snapshot)
+ license is acceptable (BSD)
+ license file is present, %license is used
+ provides/requires look OK
+ %python_provide is used
+ no scriptlets present or necessary
+ rpmlint: spelling-error and unversioned-explicit-provides warnings, both bogus
Package is APPROVED.
Thank you again for the review. New package requested.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/python-orderedset