Bug 1312939
Summary: | Review Request: mongo-c-driver - Client library written in C for MongoDB | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Remi Collet <fedora> | ||||
Component: | Package Review | Assignee: | Johan Cwiklinski <fedora> | ||||
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | rawhide | CC: | amessina, bjori, fedora, i, jesse, package-review | ||||
Target Milestone: | --- | Flags: | fedora:
fedora-review+
|
||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2016-05-21 06:29:00 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 1269056 | ||||||
Attachments: |
|
Description
Remi Collet
2016-02-29 15:06:18 UTC
*** Bug 1260254 has been marked as a duplicate of this bug. *** remi's scratch build of mongo-c-driver-1.3.3-2.remi.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=13177835 remi's scratch build of mongo-c-driver-1.3.3-2.remi.src.rpm for f24 failed http://koji.fedoraproject.org/koji/taskinfo?taskID=13177894 remi's scratch build of mongo-c-driver-1.3.3-2.remi.src.rpm for f23 failed http://koji.fedoraproject.org/koji/taskinfo?taskID=13177898 remi's scratch build of mongo-c-driver-1.3.3-2.remi.src.rpm for f23 failed http://koji.fedoraproject.org/koji/taskinfo?taskID=13179468 remi's scratch build of mongo-c-driver-1.3.3-2.remi.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=13179467 - add patch to skip online tests open https://github.com/mongodb/mongo-c-driver/pull/314 - temporarily disable test suite on F24+ (#1313018) https://github.com/remicollet/remirepo/commit/6f00a8bc2afd4197d5adf6d31e4eafdf4c15b64c - temporarily disable test suite on arm (#1303864) https://github.com/remicollet/remirepo/commit/fd955b84d82f18615dafc80c83cae2724af6311b Spec: https://raw.githubusercontent.com/remicollet/remirepo/fd955b84d82f18615dafc80c83cae2724af6311b/mongo-c-driver/mongo-c-driver.spec Srpm: http://rpms.famillecollet.com/SRPMS/mongo-c-driver-1.3.3-2.remi.src.rpm remi's scratch build of mongo-c-driver-1.3.3-2.remi.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=13187254 as bug #1313018 is i386 only, enable the test suite (x86_64 only) https://github.com/remicollet/remirepo/commit/0d34bb45f7a52f1ebd59230e249b2fcd8b41f400 Spec: https://raw.githubusercontent.com/remicollet/remirepo/0d34bb45f7a52f1ebd59230e249b2fcd8b41f400/mongo-c-driver/mongo-c-driver.spec Srpm: http://rpms.famillecollet.com/SRPMS/mongo-c-driver-1.3.3-2.remi.src.rpm Update to 1.3.4: https://github.com/remicollet/remirepo/commit/22a122f5e93fb4f42e31ffa996bf66cb039f95bc Spec: https://raw.githubusercontent.com/remicollet/remirepo/22a122f5e93fb4f42e31ffa996bf66cb039f95bc/mongo-c-driver/mongo-c-driver.spec Srpm: http://rpms.famillecollet.com/SRPMS/mongo-c-driver-1.3.4-1.remi.src.rpm Add a new option (per upstream comment) https://github.com/remicollet/remirepo/commit/865e6724cc806218cc976544639d01042d930635 Spec: https://raw.githubusercontent.com/remicollet/remirepo/865e6724cc806218cc976544639d01042d930635/mongo-c-driver/mongo-c-driver.spec Srpm: http://rpms.famillecollet.com/SRPMS/mongo-c-driver-1.3.4-2.remi.src.rpm Update to 1.3.5: https://github.com/remicollet/remirepo/commit/b568c0c9f7fb4a5f8bc46891cca3b9991c41da0b Spec: https://raw.githubusercontent.com/remicollet/remirepo/b568c0c9f7fb4a5f8bc46891cca3b9991c41da0b/mongo-c-driver/mongo-c-driver.spec Srpm: http://rpms.remirepo.net/SRPMS/mongo-c-driver-1.3.5-1.remi.src.rpm Remi, thank you for working to get this into Fedora. Do you know what is holding up the acceptance? @Anthony: we just need a reviewer ;) Add patch to enforce system crypto policies (per Guildelines, thanks @trasher for the check) https://github.com/remicollet/remirepo/commit/0ff60fa9e39f8f6a3b0ce2d58be66ff5589b104d Spec: https://github.com/remicollet/remirepo/blob/0ff60fa9e39f8f6a3b0ce2d58be66ff5589b104d/mongo-c-driver/mongo-c-driver.spec Srpm: http://rpms.remirepo.net/SRPMS/mongo-c-driver-1.3.5-2.remi.src.rpm Spec: https://raw.githubusercontent.com/remicollet/remirepo/0ff60fa9e39f8f6a3b0ce2d58be66ff5589b104d/mongo-c-driver/mongo-c-driver.spec Srpm: http://rpms.remirepo.net/SRPMS/mongo-c-driver-1.3.5-2.remi.src.rpm Created attachment 1157827 [details]
fedora-review output
All is OK except rpmlint output. I do not understand the crypto-policy-non-compliance-openssl. The patch has been applied, warnings should be gone now... Well, it is just a warning anyways (and a patch has been submitted upstream for that). For the only-non-binary-in-usr-lib; I really do not understand what is wrong; I guess it should be a false positive from rpmlint. It is also just a warning. All others rpmlint warnings can be ignored; there is no blockers... APPROVED :) Great thanks for the review! New package requested on pkgdb. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/mongo-c-driver mongo-c-driver-1.3.5-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-87a6621c07 mongo-c-driver-1.3.5-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-e002f14bbb mongo-c-driver-1.3.5-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-a4726cb8c2 mongo-c-driver-1.3.5-2.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-2ab5bab700 mongo-c-driver-1.3.5-2.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-2ab5bab700 mongo-c-driver-1.3.5-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-e002f14bbb mongo-c-driver-1.3.5-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-a4726cb8c2 mongo-c-driver-1.3.5-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-87a6621c07 Closing to unblock pending reviews mongo-c-driver-1.3.5-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. mongo-c-driver-1.3.5-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. mongo-c-driver-1.3.5-2.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. mongo-c-driver-1.3.5-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. |