Bug 1313233
| Summary: | Wrong permissions set on previous copy of truncated files inside trash directory | ||
|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Anoop C S <anoopcs> |
| Component: | trash-xlator | Assignee: | Anoop C S <anoopcs> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 3.7.8 | CC: | bugs, jthottan |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Fixed In Version: | glusterfs-3.7.9 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 1309342 | Environment: | |
| Last Closed: | 2016-04-19 07:16:14 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1309342 | ||
| Bug Blocks: | 1309567 | ||
|
Description
Anoop C S
2016-03-01 08:44:46 UTC
REVIEW: http://review.gluster.org/13555 (features/trash: Retain file permissions during truncate) posted (#1) for review on release-3.7 by Anoop C S (anoopcs) COMMIT: http://review.gluster.org/13555 committed in release-3.7 by Vijay Bellur (vbellur) ------ commit 82674a299a3fa9b969c494d2d0a3e72600323af8 Author: Anoop C S <anoopcs> Date: Wed Feb 17 15:50:05 2016 +0530 features/trash: Retain file permissions during truncate Consider the situation where directory path for a truncated file does not exists under trash directory. In this scenario after creating the required path we failed to create the orginal file with proper permissions. Eventhough we try to fetch permissions from local->origpath, it was never filled with required value in truncate and ftruncate call paths. This change will copy original location to local->origpath inside both fop handling functions. >Change-Id: If5930b6d368d08e58f04db999f3f9edb9250bcb9 >BUG: 1309342 >Signed-off-by: Anoop C S <anoopcs> >Reviewed-on: http://review.gluster.org/13461 >Smoke: Gluster Build System <jenkins.com> >CentOS-regression: Gluster Build System <jenkins.com> >NetBSD-regression: NetBSD Build System <jenkins.org> >Reviewed-by: jiffin tony Thottan <jthottan> >Reviewed-by: Jeff Darcy <jdarcy> (cherry picked from commit b1cb581424305592fac5394a578b307117b22fe7) Change-Id: I5d964b4d802551bb04a7011f88edb59a1231238e BUG: 1313233 Signed-off-by: Anoop C S <anoopcs> Reviewed-on: http://review.gluster.org/13555 NetBSD-regression: NetBSD Build System <jenkins.org> Smoke: Gluster Build System <jenkins.com> CentOS-regression: Gluster Build System <jenkins.com> Reviewed-by: jiffin tony Thottan <jthottan> Reviewed-by: Vijay Bellur <vbellur> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.9, please open a new bug report. glusterfs-3.7.9 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] https://www.gluster.org/pipermail/gluster-users/2016-March/025922.html [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user |