Bug 1313352

Summary:	Dist-geo-rep: Support geo-replication to work with sharding
Product:	[Red Hat Storage] Red Hat Gluster Storage	Reporter:	Sahina Bose <sabose>
Component:	geo-replication	Assignee:	Kotresh HR <khiremat>
Status:	CLOSED ERRATA	QA Contact:	Rahul Hinduja <rhinduja>
Severity:	unspecified	Docs Contact:
Priority:	high
Version:	rhgs-3.1	CC:	avishwan, bugs, chrisw, csaba, khiremat, nlevinki, rcyriac, rhinduja, sabose
Target Milestone:	---	Keywords:	ZStream
Target Release:	RHGS 3.1.3
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.9-1	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1265148	Environment:
Last Closed:	2016-06-23 05:09:52 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1265148
Bug Blocks:	1258386, 1299184

Description Sahina Bose 2016-03-01 12:48:25 UTC

+++ This bug was initially created as a clone of Bug #1265148 +++

Description of problem:
This bug tracks all the changes required for geo-replication to work with
sharding.

Requirements as per design:
  1. Both master and slave should be sharded
  2. Sharding configurations should be retained same as in master

Version-Release number of selected component (if applicable):
mainline

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:
Geo-replication does not work with sharding

Expected results:
Geo-replication should work with sharding.

Additional info:

--- Additional comment from Vijay Bellur on 2015-10-13 08:04:28 EDT ---

REVIEW: http://review.gluster.org/12228 (features/shard: Support geo-rep for sharded volume) posted (#5) for review on master by Kotresh HR (khiremat)

--- Additional comment from Vijay Bellur on 2015-10-26 08:57:51 EDT ---

COMMIT: http://review.gluster.org/12228 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit 8216ecb871c8d74edcc46b7f13d1e1879be25de1
Author: Kotresh HR <khiremat>
Date:   Thu Sep 24 15:42:14 2015 +0530

    features/shard: Support geo-rep for sharded volume
    
    Approach:
          Shard xlator on slave side is by passed for all the fops
    to geo-rep mount. So each shard on master is considered as a
    separate file for geo-rep and it syncs them separately on to
    slave. The extended attribute in which shard maintains the
    size is also synced from master and shard on slave doesn't
    calculate by itself.
    
    Pre-requisites:
          1. If master is sharded volume, slave also should be sharded.
          2. Slave's shard configurations should be same as master.
          3. Geo-rep config of xattr sync should not be disabled.
    
    All other dependant patches:
          1. http://review.gluster.org/#/c/12205/
          2. http://review.gluster.org/#/c/12206/
          3. http://review.gluster.org/#/c/12225/
          4. http://review.gluster.org/#/c/12226/
    
    Change-Id: I474220d69fa030b1e06a4fa0868c34fabe02efcf
    BUG: 1265148
    Signed-off-by: Kotresh HR <khiremat>
    Reviewed-on: http://review.gluster.org/12228
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: Krutika Dhananjay <kdhananj>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>

--- Additional comment from Vijay Bellur on 2015-10-27 04:38:28 EDT ---

REVIEW: http://review.gluster.org/12226 (geo-rep: Handle FXATTROP and XATTROP) posted (#5) for review on master by Kotresh HR (khiremat)

--- Additional comment from Vijay Bellur on 2015-10-27 05:24:32 EDT ---

REVIEW: http://review.gluster.org/12205 (geo-rep: Fix syncing chown in xsync crawl) posted (#3) for review on master by Kotresh HR (khiremat)

--- Additional comment from Vijay Bellur on 2015-10-28 00:52:48 EDT ---

REVIEW: http://review.gluster.org/12226 (geo-rep: Handle FXATTROP and XATTROP) posted (#6) for review on master by Kotresh HR (khiremat)

--- Additional comment from Vijay Bellur on 2015-11-23 01:49:19 EST ---

COMMIT: http://review.gluster.org/12225 committed in master by Venky Shankar (vshankar) 
------
commit 8805a4c65bf9c725cb26bb6979f3ebd62748138f
Author: Kotresh HR <khiremat>
Date:   Tue Sep 22 16:18:29 2015 +0530

    features/changelog: Capture FXATTROP and XATTROP in changelog
    
    GEO-REP INTEROP WITH SHARD FEATURE
    
    shard xlator updates size of the file using FXATTROP
    or XATTROP. Hence record the same in changelog.
    
    Change-Id: Ie0c21e9326da05ea78dc1ef3fd32a90ef38b4bb9
    BUG: 1265148
    Signed-off-by: Kotresh HR <khiremat>
    Reviewed-on: http://review.gluster.org/12225
    Tested-by: NetBSD Build System <jenkins.org>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Venky Shankar <vshankar>

Comment 3 Aravinda VK 2016-03-23 06:25:39 UTC

Patch for this bug is available in rhgs-3.1.3 branch as part of rebase from upstream release-3.7.9.

Comment 5 Rahul Hinduja 2016-05-29 17:45:44 UTC

Verified with 3.1.3 builds, latest with glusterfs-3.7.9-6. 

Positive cases like sync via changelog. 
fops like: create,chmod,chown,chgrp,symlink,hardlink,truncate,rename,remove are synced to slave properly. Number of shards and checksum matches between master and slave. 

Few issues were reported and tracked in separate bz like: 1340652, 1340645, 1332080

Moving this bug to verified state since the shard files gets sync. New issues will be tracked separately.

Comment 7 errata-xmlrpc 2016-06-23 05:09:52 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1240