Bug 1313881
| Summary: | [networking] Adapt to the lack of CFG property of NICS in VDSM netinfo | ||
|---|---|---|---|
| Product: | [oVirt] ovirt-hosted-engine-setup | Reporter: | Simone Tiraboschi <stirabos> |
| Component: | Network | Assignee: | Simone Tiraboschi <stirabos> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Meni Yakove <myakove> |
| Severity: | high | Docs Contact: | |
| Priority: | high | ||
| Version: | 2.0.0 | CC: | bugs, danken, dougsland, mburman, mmirecki, sbonazzo, stirabos, ylavi |
| Target Milestone: | ovirt-4.1.0-alpha | Keywords: | CodeChange |
| Target Release: | 2.1.0 | Flags: | rule-engine:
ovirt-4.1+
rule-engine: planning_ack+ sbonazzo: devel_ack+ mavital: testing_ack+ |
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-04-27 09:37:31 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | Integration | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1313872 | ||
|
Description
Simone Tiraboschi
2016-03-02 14:22:05 UTC
dan, can you please advise on what should be used instead of netinfo.CachingNetInfo ? We have seen that it is dangerous to depend on vdsm internal module structure. Vdsm has a public API, and only it should be used by components outside the Vdsm git tree. Vdsm has no test nor a commitment to keep internal functions, so please call getVdsCaps and parse it, just like Engine does. Moving from 4.0 alpha to 4.0 beta since 4.0 alpha has been already released and bug is not ON_QA. oVirt 4.0 beta has been released, moving to RC milestone. oVirt 4.0 beta has been released, moving to RC milestone. What is the action item on this bug? In vdsm from branch 40, netinfo still contains the cfg element. It has been recently removed on master: https://gerrit.ovirt.org/#/c/58226 but it sill requires some work to report otherwise missing information: https://gerrit.ovirt.org/#/c/58351/6 *** Bug 1347438 has been marked as a duplicate of this bug. *** Can you add the ticket for adding the missing API info? Sorry, Yaniv, I do not understand your request. could you rephrase it? It was https://gerrit.ovirt.org/#/c/58351 but I see that now it's in. Hi Simone, Please explain how exactly this should be tested and verified? I see it has CodeChange Keywords. I don't see the cfg property on vdsCaps anymore, is it good enough? If the change is on the hosted-engine code, then please move it to verified as i'm not sure what exactly should be tested here. QE needs to verify that all network-related hosted-engine flows still work. There should be no functional change visible to the user. Tested with ovirt-hosted-engine-setup-2.1.0.5-1.el7ev.noarch |