Bug 1313975

Summary:	RKT Should ship with /var/lib/rkt, so we can label it correctly with SELinux.
Product:	[Fedora] Fedora	Reporter:	Daniel Walsh <dwalsh>
Component:	rkt	Assignee:	Lokesh Mandvekar <lsm5>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	amurdaca, iago, lsm5, muadda
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	rkt-1.1.0-3.git5a19dc6.fc25	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-03-02 20:34:03 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Daniel Walsh 2016-03-02 18:09:36 UTC

Comment 1 Lokesh Mandvekar 2016-03-02 20:10:56 UTC

it does setup /var/lib/rkt, there's a %{_bindir}/rkt-setup-data-dir.sh that runs on %post to create the dir structure in /var/lib/rkt. Just that I excluded it from %files so that it didn't get removed if someone uninstalled rkt. Kinda like /var/lib/docker. Do we want this removed on uninstall?

Comment 2 Daniel Walsh 2016-03-02 20:12:35 UTC

It would only get removed if there was no data in it, so yes it should be in the payload.

Comment 3 Lokesh Mandvekar 2016-03-02 20:34:03 UTC

ah yup, you're right. Reverted it.


commit 1e03a118cd40db059ea281b082a1aa96394b69d4
Author: Lokesh Mandvekar <lsm5>
Date:   Wed Mar 2 20:28:20 2016

    Resolves: rhbz#1313975 - %files owns /var/lib/rkt
    
    Signed-off-by: Lokesh Mandvekar <lsm5>

diff --git a/rkt.spec b/rkt.spec
index 10939a9..49d233b 100644
--- a/rkt.spec
+++ b/rkt.spec
@@ -303,6 +303,7 @@ exit 0
 %{_libexecdir}/%{name}/stage1-host.aci
 %{_unitdir}/%{name}*
 %{_datadir}/bash-completion/completions/%{name}
+%{_sharedstatedir}/%{name}

 %changelog
 * Wed Mar 02 2016 Lokesh Mandvekar <lsm5> - 1.1.0-2.git5a19dc6