Bug 1313975 - RKT Should ship with /var/lib/rkt, so we can label it correctly with SELinux.
Summary: RKT Should ship with /var/lib/rkt, so we can label it correctly with SELinux.
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: rkt
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Lokesh Mandvekar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-03-02 18:09 UTC by Daniel Walsh
Modified: 2016-03-02 20:34 UTC (History)
4 users (show)

Fixed In Version: rkt-1.1.0-3.git5a19dc6.fc25
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-03-02 20:34:03 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Daniel Walsh 2016-03-02 18:09:36 UTC

Comment 1 Lokesh Mandvekar 2016-03-02 20:10:56 UTC
it does setup /var/lib/rkt, there's a %{_bindir}/rkt-setup-data-dir.sh that runs on %post to create the dir structure in /var/lib/rkt. Just that I excluded it from %files so that it didn't get removed if someone uninstalled rkt. Kinda like /var/lib/docker. Do we want this removed on uninstall?

Comment 2 Daniel Walsh 2016-03-02 20:12:35 UTC
It would only get removed if there was no data in it, so yes it should be in the payload.

Comment 3 Lokesh Mandvekar 2016-03-02 20:34:03 UTC
ah yup, you're right. Reverted it.


commit 1e03a118cd40db059ea281b082a1aa96394b69d4
Author: Lokesh Mandvekar <lsm5>
Date:   Wed Mar 2 20:28:20 2016

    Resolves: rhbz#1313975 - %files owns /var/lib/rkt
    
    Signed-off-by: Lokesh Mandvekar <lsm5>

diff --git a/rkt.spec b/rkt.spec
index 10939a9..49d233b 100644
--- a/rkt.spec
+++ b/rkt.spec
@@ -303,6 +303,7 @@ exit 0
 %{_libexecdir}/%{name}/stage1-host.aci
 %{_unitdir}/%{name}*
 %{_datadir}/bash-completion/completions/%{name}
+%{_sharedstatedir}/%{name}

 %changelog
 * Wed Mar 02 2016 Lokesh Mandvekar <lsm5> - 1.1.0-2.git5a19dc6


Note You need to log in before you can comment on or make changes to this bug.