Bug 1314181

Summary:	Wrong checkbox tooltip behavior
Product:	[oVirt] ovirt-engine	Reporter:	Idan Shaby <ishaby>
Component:	Frontend.WebAdmin	Assignee:	Alexander Wels <awels>
Status:	CLOSED WONTFIX	QA Contact:	Pavel Novotny <pnovotny>
Severity:	unspecified	Docs Contact:
Priority:	medium
Version:	3.6.2	CC:	amureini, bugs, ishaby, mgoldboi, oourfali, pstehlik, sbonazzo, tnisan
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-07-05 12:54:03 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	UX	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Idan Shaby 2016-03-03 08:09:07 UTC

Description of problem:
EntityModel::setIsChangeable(boolean value) has a wrong behavioral pattern.

Version-Release number of selected component (if applicable):
45766401389799d916910e9e0aedc0572d279114

How reproducible:
100%

Steps to Reproduce:
1. Create a vm.
2. Go to the Disks sub tab and click new.
3. Click on "Direct LUN" and switch to VirtIO-SCSI interface.
4. Point to the "Read Only" checkbox label on the right and see the tooltip (correct behavior).
5. Disable "Enable SCSI Pass-Through", point to the "Read Only" checkbox label and see the same tooltip again (incorrect behavior since the read only checkbox is changeable).
6. Enable "Enable SCSI Pass-Through", point to the "Read Only" checkbox label and see that the tooltip is not shown (incorrect behavior since the read only checkbox is not changeable).
7. Disable "Enable SCSI Pass-Through", point to the "Read Only" checkbox label and see that the tooltip is not shown (correct).
8. Enable "Enable SCSI Pass-Through", point to the "Read Only" checkbox label and see that the tooltip is shown (correct).
9. Disable "Enable SCSI Pass-Through", point to the "Read Only" checkbox label and see that the tooltip is shown (incorrect).
10. Enable it again and see that this behavior repeats itself over and over again: incorrect, correct, correct, incorrect, incorrect, correct, correct, incorrect, incorrect, correct...

Actual results:
Wrong behavior

Expected results:
Consistent and correct behavior.

Additional info:
Also happens when using EntityModel::setIsChangeable(boolean value, String reason).

Comment 1 Idan Shaby 2016-03-13 14:40:31 UTC

Since this bug still occurs, and since patch [1] was rejected in upstream, I am moving it back to "New".

[1] For future reference:
https://gerrit.ovirt.org/#/c/54267/ - webadmin: postpone the raise of onPropertyChanged event

Comment 2 Oved Ourfali 2016-03-16 07:32:28 UTC

Idan - will you be looking at it, or shall I assign someone from the UX team?

Comment 3 Idan Shaby 2016-03-16 08:03:40 UTC

No, there was a misunderstanding and I was about to reset it the assignee again.
Thanks

Comment 4 Pavel Novotny 2016-05-11 17:19:16 UTC

FailedQA in rhevm-webadmin-portal-3.6.6.2-0.1.el6 (build 3.6.6-3).

Exactly following steps to reproduce from comment 0 and the tooltip behavior is still the same as is described there.

Comment 5 Red Hat Bugzilla Rules Engine 2016-05-11 17:19:23 UTC

Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 6 Alexander Wels 2016-05-13 15:12:47 UTC

So I reverified this works on master. I also verified the code that fixes it was back ported to the 3.6 branch, and the 3.6.6 tag. Same for down stream. All the code is identical, however it doesn't work for 3.6.6 while its fine on master.